Just checking - there is no way to tell bazel to look somewhere else for whatever 'external' means to it? It's a kinda big ugly change but it's not a functional change. If anything it might break some downstream builds that rely on the current structure too. But such is life for developers? I don't have a strong reason we can't.
On Thu, Mar 17, 2022 at 1:47 PM Alkis Evlogimenos <alkis.evlogime...@databricks.com.invalid> wrote: > Hi Spark devs. > > The Apache Spark repo has a top level external/ directory. This is a > reserved name for the bazel build system and it causes all sorts of > problems: some can be worked around and some cannot (for some details on > one that cannot see > https://github.com/hedronvision/bazel-compile-commands-extractor/issues/30 > ). > > Some forks of Apache Spark use bazel as a build system. It would be nice > if we can make this change in Apache Spark without resorting to > complex renames/merges whenever changes are pulled from upstream. > > As such I proposed to rename external/ directory to want to rename the > external/ directory to something else [SPARK-38569 > <https://issues.apache.org/jira/browse/SPARK-38569>]. I also sent a > tentative [PR-35874 <https://github.com/apache/spark/pull/35874>] that > renames external/ to vendor/. > > My questions to you are: > 1. Are there any objections to renaming external to X? > 2. Is vendor a good new name for external? > > Cheers, >
