Thanks for testing it in your environment!
> This is a minor issue itself, and only impacts the metrics for push-based > shuffle, but it will essentially completely eliminate the effort > in SPARK-36620. Based on my understanding, this is not a regression. It only affects the new enhancements https://issues.apache.org/jira/browse/SPARK-36620 If so, it does not block the release RC. We should still fix it in 3.4 and the fix will be available in the next maintenance releases. Xiao Ye Zhou <zhouye...@gmail.com> 于2023年4月11日周二 17:14写道： > Manually tested the binary in our cluster. > Started spark-shell application with some shuffle. Found one issue which > is related to push based shuffle client side metrics introduced in > https://github.com/apache/spark/pull/36165. > Filed a ticket https://issues.apache.org/jira/browse/SPARK-43100, posted > PR there, and verified that the PR fixes the issue. > > This is a minor issue itself, and only impacts the metrics for push-based > shuffle, but it will essentially completely eliminate the effort > in SPARK-36620. > > Would like to raise this issue in the voting thread, but hold my > non-binding -1 here. > > > On Tue, Apr 11, 2023 at 1:06 AM Peter Toth <peter.t...@gmail.com> wrote: > >> +1 >> >> Jia Fan <fan...@apache.org> ezt írta (időpont: 2023. ápr. 11., K, 9:09): >> >>> +1 >>> >>> Wenchen Fan <cloud0...@gmail.com> 于2023年4月11日周二 14:32写道： >>> >>>> +1 >>>> >>>> On Tue, Apr 11, 2023 at 9:57 AM Yuming Wang <wgy...@gmail.com> wrote: >>>> >>>>> +1. >>>>> >>>>> On Tue, Apr 11, 2023 at 9:14 AM Yikun Jiang <yikunk...@gmail.com> >>>>> wrote: >>>>> >>>>>> +1 (non-binding) >>>>>> >>>>>> Also ran the docker image related test (signatures/standalone/k8s) >>>>>> with rc7: https://github.com/apache/spark-docker/pull/32 >>>>>> >>>>>> Regards, >>>>>> Yikun >>>>>> >>>>>> >>>>>> On Tue, Apr 11, 2023 at 4:44 AM Jacek Laskowski <ja...@japila.pl> >>>>>> wrote: >>>>>> >>>>>>> +1 >>>>>>> >>>>>>> * Built fine with Scala 2.13 >>>>>>> and -Pkubernetes,hadoop-cloud,hive,hive-thriftserver,scala-2.13,volcano >>>>>>> * Ran some demos on Java 17 >>>>>>> * Mac mini / Apple M2 Pro / Ventura 13.3.1 >>>>>>> >>>>>>> Pozdrawiam, >>>>>>> Jacek Laskowski >>>>>>> ---- >>>>>>> "The Internals Of" Online Books <https://books.japila.pl/> >>>>>>> Follow me on https://twitter.com/jaceklaskowski >>>>>>> >>>>>>> <https://twitter.com/jaceklaskowski> >>>>>>> >>>>>>> >>>>>>> On Sat, Apr 8, 2023 at 1:30 AM Xinrong Meng < >>>>>>> xinrong.apa...@gmail.com> wrote: >>>>>>> >>>>>>>> Please vote on releasing the following candidate(RC7) as Apache >>>>>>>> Spark version 3.4.0. >>>>>>>> >>>>>>>> The vote is open until 11:59pm Pacific time *April 12th* and >>>>>>>> passes if a majority +1 PMC votes are cast, with a minimum of 3 +1 >>>>>>>> votes. >>>>>>>> >>>>>>>> [ ] +1 Release this package as Apache Spark 3.4.0 >>>>>>>> [ ] -1 Do not release this package because ... >>>>>>>> >>>>>>>> To learn more about Apache Spark, please see >>>>>>>> http://spark.apache.org/ >>>>>>>> >>>>>>>> The tag to be voted on is v3.4.0-rc7 (commit >>>>>>>> 87a5442f7ed96b11051d8a9333476d080054e5a0): >>>>>>>> https://github.com/apache/spark/tree/v3.4.0-rc7 >>>>>>>> >>>>>>>> The release files, including signatures, digests, etc. can be found >>>>>>>> at: >>>>>>>> https://dist.apache.org/repos/dist/dev/spark/v3.4.0-rc7-bin/ >>>>>>>> >>>>>>>> Signatures used for Spark RCs can be found in this file: >>>>>>>> https://dist.apache.org/repos/dist/dev/spark/KEYS >>>>>>>> >>>>>>>> The staging repository for this release can be found at: >>>>>>>> >>>>>>>> https://repository.apache.org/content/repositories/orgapachespark-1441 >>>>>>>> >>>>>>>> The documentation corresponding to this release can be found at: >>>>>>>> https://dist.apache.org/repos/dist/dev/spark/v3.4.0-rc7-docs/ >>>>>>>> >>>>>>>> The list of bug fixes going into 3.4.0 can be found at the >>>>>>>> following URL: >>>>>>>> https://issues.apache.org/jira/projects/SPARK/versions/12351465 >>>>>>>> >>>>>>>> This release is using the release script of the tag v3.4.0-rc7. >>>>>>>> >>>>>>>> >>>>>>>> FAQ >>>>>>>> >>>>>>>> ========================= >>>>>>>> How can I help test this release? >>>>>>>> ========================= >>>>>>>> If you are a Spark user, you can help us test this release by taking >>>>>>>> an existing Spark workload and running on this release candidate, >>>>>>>> then >>>>>>>> reporting any regressions. >>>>>>>> >>>>>>>> If you're working in PySpark you can set up a virtual env and >>>>>>>> install >>>>>>>> the current RC and see if anything important breaks, in the >>>>>>>> Java/Scala >>>>>>>> you can add the staging repository to your projects resolvers and >>>>>>>> test >>>>>>>> with the RC (make sure to clean up the artifact cache before/after >>>>>>>> so >>>>>>>> you don't end up building with an out of date RC going forward). >>>>>>>> >>>>>>>> =========================================== >>>>>>>> What should happen to JIRA tickets still targeting 3.4.0? >>>>>>>> =========================================== >>>>>>>> The current list of open tickets targeted at 3.4.0 can be found at: >>>>>>>> https://issues.apache.org/jira/projects/SPARK and search for >>>>>>>> "Target Version/s" = 3.4.0 >>>>>>>> >>>>>>>> Committers should look at those and triage. Extremely important bug >>>>>>>> fixes, documentation, and API tweaks that impact compatibility >>>>>>>> should >>>>>>>> be worked on immediately. Everything else please retarget to an >>>>>>>> appropriate release. >>>>>>>> >>>>>>>> ================== >>>>>>>> But my bug isn't fixed? >>>>>>>> ================== >>>>>>>> In order to make timely releases, we will typically not hold the >>>>>>>> release unless the bug in question is a regression from the previous >>>>>>>> release. That being said, if there is something which is a >>>>>>>> regression >>>>>>>> that has not been correctly targeted please ping me or a committer >>>>>>>> to >>>>>>>> help target the issue. >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Xinrong Meng >>>>>>>> >>>>>>> > > -- > > *Zhou, Ye **周晔* >
