+1 -- even if it's not perfect now is the time to change default values On Sat, Apr 13, 2024 at 4:11 PM Hyukjin Kwon <gurwls...@apache.org> wrote:
> +1 > > On Sun, Apr 14, 2024 at 7:46 AM Chao Sun <sunc...@apache.org> wrote: > >> +1. >> >> This feature is very helpful for guarding against correctness issues, >> such as null results due to invalid input or math overflows. It’s been >> there for a while now and it’s a good time to enable it by default as Spark >> enters the next major release. >> >> On Sat, Apr 13, 2024 at 3:27 PM Dongjoon Hyun <dongj...@apache.org> >> wrote: >> >>> I'll start from my +1. >>> >>> Dongjoon. >>> >>> On 2024/04/13 22:22:05 Dongjoon Hyun wrote: >>> > Please vote on SPARK-44444 to use ANSI SQL mode by default. >>> > The technical scope is defined in the following PR which is >>> > one line of code change and one line of migration guide. >>> > >>> > - DISCUSSION: >>> > https://lists.apache.org/thread/ztlwoz1v1sn81ssks12tb19x37zozxlz >>> > - JIRA: https://issues.apache.org/jira/browse/SPARK-44444 >>> > - PR: https://github.com/apache/spark/pull/46013 >>> > >>> > The vote is open until April 17th 1AM (PST) and passes >>> > if a majority +1 PMC votes are cast, with a minimum of 3 +1 votes. >>> > >>> > [ ] +1 Use ANSI SQL mode by default >>> > [ ] -1 Do not use ANSI SQL mode by default because ... >>> > >>> > Thank you in advance. >>> > >>> > Dongjoon >>> > >>> >>> --------------------------------------------------------------------- >>> To unsubscribe e-mail: dev-unsubscr...@spark.apache.org >>> >>> -- Twitter: https://twitter.com/holdenkarau Books (Learning Spark, High Performance Spark, etc.): https://amzn.to/2MaRAG9 <https://amzn.to/2MaRAG9> YouTube Live Streams: https://www.youtube.com/user/holdenkarau
