So I went through org.apache:apache:11 to look for overlaps or potential conflicts with Spark's poms -- less than I expected. I'm not sure whether we should add <description> and <organization> (apache-incubating instead of apache) elements to the <project> of spark/pom.xml. Other than that, we could drop the maven-jar-plugin from spark/pom.xml, since it already specified in a completely compatible way in org.apache:apache. I didn't find any other problems other than that in <scm>, which Patrick has already addressed.
On Fri, Sep 13, 2013 at 11:59 AM, Patrick Wendell <[email protected]>wrote: > I'll post another RC in a bit which addresses Mark's comments (though > please continue to provide feedback on this one!). > > Suresh - it's signed with the following key: > > http://people.apache.org/~pwendell/9E4FE3AF.asc > > > > On Fri, Sep 13, 2013 at 11:28 AM, Mark Hamstra <[email protected]> > wrote: > > [X] -1 Do not release this package because ... > > > > Prior, out-of-band discussion: > > > > Thanks for the insight Mark, we need to move this discussion to the > >> main VOTE thread in dev@ list to be official. > >> > >> Mark, could you kind reply to Patrick VOTE email thread with the -1 > >> vote to make sure community know that there are missing pieces in the > >> release artifacts proposed by Spark's RE (Patrick) > >> > >> Thanks, > >> > >> Henry > >> > >> > >> On Thu, Sep 12, 2013 at 10:57 PM, Mark Hamstra <[email protected] > > > >> wrote: > >> > Yeah, that may get tricky, because the check of the tests in the > >> 'prepare' > >> > step and the running of the deploy goal in the 'perform' step (excuse > my > >> > calling it 'release' previously) will want to change the build > >> dependencies. > >> > We may end up needing to do as Patrick has been doing but then run a > >> > separate script to make sure that the yarn and repl-bin modules get > >> properly > >> > versioned, tagged, and uploaded. Maybe a maven-release-plugin expert > >> knows > >> > how to get it do just what we want, but I certainly don't see how > myself > >> > right now. > >> > > >> > > >> > On Thu, Sep 12, 2013 at 10:45 PM, Matei Zaharia < > [email protected] > >> > > >> > wrote: > >> >> > >> >> Hmm, one potentially nasty issue here is if spark-core ends up > depending > >> >> on hadoop-client 2.0.x instead of 1.0.4 by default with these > settings. > >> We > >> >> should make sure that doesn't happen. > >> >> > >> >> If you'll make another RC, here are a few other small fixes I'd > suggest: > >> >> > >> >> - In the title tag of docs/_layout/global.html, use > >> >> site.SPARK_VERSION_SHORT instead of SPARK_VERSION (it's kind of > verbose > >> now) > >> >> > >> >> - Fix the jets3t version thing mentioned here: > >> >> https://github.com/mesos/spark/pull/919 (just remove the unneeded > >> version > >> >> from core/pom.xml) > >> >> > >> >> Matei > >> >> > >> >> On Sep 12, 2013, at 10:25 PM, Patrick Wendell <[email protected]> > >> wrote: > >> >> > >> >> > Oh I see - okay I'll try to make sure they (a) get pushed and (b) > have > >> >> > the correct version. Thanks for bringing this up, would have > totally > >> >> > missed it otherwise. > >> >> > > >> >> > On Thu, Sep 12, 2013 at 10:20 PM, Mark Hamstra < > >> [email protected]> > >> >> > wrote: > >> >> >> I just mean that with the yarn and repl-bin poms still specifying > >> >> >> SNAPSHOT > >> >> >> versions, any maven build that tries to use the hadoop2-yarn or > >> >> >> repl-bin > >> >> >> profile will not work because those modules will not be able to > find > >> a > >> >> >> SNAPSHOT parent pom. Including those profiles in the prepare and > >> >> >> release > >> >> >> step should fix the problem, but you may need to manually sync up > the > >> >> >> version of those two pom files first. > >> >> >> > >> >> >> > >> >> >> On Thu, Sep 12, 2013 at 10:16 PM, Patrick Wendell < > >> [email protected]> > >> >> >> wrote: > >> >> >>> > >> >> >>> Hey Mark, > >> >> >>> > >> >> >>> I haven't been including those - I'll use that flag and try to > >> publish > >> >> >>> again. The last sentence there "the maven build is broken" does > that > >> >> >>> refer to an additional problem, or just the problem of me not > >> >> >>> including the flag. > >> >> >>> > >> >> >>> - Patrick > >> >> >>> > >> >> >>> On Thu, Sep 12, 2013 at 10:11 PM, Mark Hamstra > >> >> >>> <[email protected]> > >> >> >>> wrote: > >> >> >>>> It's a definite "do not release" from me because you are still > not > >> >> >>>> picking > >> >> >>>> up all of the modules in your prepare and release. Are you > >> including > >> >> >>>> "-Phadoop2-yarn,repl-bin" on the command line for your "mvn > >> prepare" > >> >> >>>> and > >> >> >>>> "mvn release"? Because the yarn module and repl-bin module are > not > >> >> >>>> being > >> >> >>>> processed by the maven-release-plugin, so the pom files for > those > >> >> >>>> modules > >> >> >>>> still show their version as 0.8.0-incubating-SNAPSHOT instead of > >> >> >>>> 0.8.0-incubating. That means that the maven build is broken. > >> >> >>>> > >> > >> > > On Thu, Sep 12, 2013 at 3:57 PM, Patrick Wendell <[email protected]> > wrote: > > > >> Please vote on releasing the following candidate as Apache Spark > >> (incubating) version 0.8.0. This will be the first incubator release for > >> Spark in Apache. > >> > >> The tag to be voted on is v0.8.0-incubating (commit ffacd17): > >> > https://github.com/apache/incubator-spark/releases/tag/v0.8.0-incubating > >> > >> The release files, including signatures, digests, etc can be found at: > >> http://people.apache.org/~pwendell/spark-0.8.0-incubating-rc3/files/ > >> > >> The staging repository for this release can be found at: > >> > >> > https://repository.apache.org/content/repositories/orgapachespark-034/org/apache/spark/ > >> > >> The documentation corresponding to this release can be found at: > >> http://people.apache.org/~pwendell/spark-0.8.0-incubating-rc3/docs/ > >> > >> Please vote on releasing this package as Apache Spark 0.8.0-incubating! > >> > >> The vote is open until Saturday, June 13th at 23:00 UTC and passes if > >> a majority of at least 3 +1 IPMC votes are cast. > >> > >> [ ] +1 Release this package as Apache Spark 0.8.0-incubating > >> [X] -1 Do not release this package because ... > >> > >> To learn more about Apache Spark, please see > >> http://spark.incubator.apache.org/ > >> >
