[GitHub] incubator-spark pull request: SPARK-1111: URL Validation Throws Er...

[hsaputra]

Github user hsaputra commented on a diff in the pull request:

    https://github.com/apache/incubator-spark/pull/625#discussion_r9956945
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/ClientArguments.scala 
---
    @@ -115,3 +110,7 @@ private[spark] class ClientArguments(args: 
Array[String]) {
         System.exit(exitCode)
       }
     }
    +
    +object ClientArguments {
    +  def isValidJarUrl(s: String) = s.matches("(.+):(.+)jar")
    --- End diff --
    
    Ah yes
    
    scala> val test = new java.net.URL("hdfs://test.jar")
    java.net.MalformedURLException: unknown protocol: hdfs
        at java.net.URL.<init>(URL.java:574)
    
    I thought java.net.URL accepts custom scheme =(
    Agree about messed up naming usage. 
    
    +1 
    
    Thanks for the explanation! =)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastruct...@apache.org or file a JIRA ticket with INFRA.
---