[ https://issues.apache.org/jira/browse/SQOOP-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245777#comment-13245777 ]
jirapos...@reviews.apache.org commented on SQOOP-473: ----------------------------------------------------- ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4584/#review6665 ----------------------------------------------------------- Ship it! - Bilung On 2012-04-03 19:13:20, Cheolsoo Park wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/4584/ bq. ----------------------------------------------------------- bq. bq. (Updated 2012-04-03 19:13:20) bq. bq. bq. Review request for Sqoop. bq. bq. bq. Summary bq. ------- bq. bq. All-tables import fails with MySQL: bq. bq. https://issues.apache.org/jira/browse/SQOOP-473 bq. bq. The change include: bq. bq. 1) Modify toJavaType(), toHiveType(), and toAvroType() methods. bq. 2) Add new unit test for MySQL all-tables import (subclassing TestAllTables). bq. 3) Minor changes to TestAllTables class to make it available for non-Hsqldb servers. bq. bq. bq. This addresses bug SQOOP-473. bq. https://issues.apache.org/jira/browse/SQOOP-473 bq. bq. bq. Diffs bq. ----- bq. bq. src/java/org/apache/sqoop/hive/TableDefWriter.java bfac391 bq. src/java/org/apache/sqoop/manager/ConnManager.java 26a2a82 bq. src/java/org/apache/sqoop/manager/MySQLManager.java 3254a2c bq. src/java/org/apache/sqoop/manager/OracleManager.java 30401c5 bq. src/java/org/apache/sqoop/mapreduce/JdbcExportJob.java a7ea834 bq. src/java/org/apache/sqoop/orm/AvroSchemaGenerator.java ff39801 bq. src/java/org/apache/sqoop/orm/ClassWriter.java 986934d bq. src/test/com/cloudera/sqoop/TestAllTables.java e6561e9 bq. src/test/com/cloudera/sqoop/manager/MySQLAllTablesTest.java e69de29 bq. bq. Diff: https://reviews.apache.org/r/4584/diff bq. bq. bq. Testing bq. ------- bq. bq. 1) Verified that MySQL all-tables import is fixed using new unit test. bq. 2) Ran ant test, ant test -Dthirdparty=true, and ant checkstyle. bq. bq. bq. Thanks, bq. bq. Cheolsoo bq. bq. > Sqoop import-all-tables fails with MySQL connector > -------------------------------------------------- > > Key: SQOOP-473 > URL: https://issues.apache.org/jira/browse/SQOOP-473 > Project: Sqoop > Issue Type: Bug > Components: connectors > Affects Versions: 1.4.1-incubating > Reporter: Prashant Gokhale > Assignee: Cheolsoo Park > Attachments: SQOOP-473.patch > > > Sqoop command > sqoop import-all-tables --connect jdbc:mysql://xxxx/mysqltestdb2 > --username=xxxx --warehouse-dir output-dir/alltables > Output: > {noformat} > 12/03/29 10:42:20 INFO manager.MySQLManager: Preparing to use a MySQL > streaming resultset. > 12/03/29 10:42:21 INFO tool.CodeGenTool: Beginning code generation > 12/03/29 10:42:21 INFO manager.SqlManager: Executing SQL statement: SELECT > t.* FROM `testtable` AS t LIMIT 1 > 12/03/29 10:42:21 ERROR sqoop.Sqoop: Got exception running Sqoop: > java.lang.NullPointerException > java.lang.NullPointerException > at > org.apache.sqoop.manager.ConnManager.getColumnTypeNames(ConnManager.java:306) > at > org.apache.sqoop.manager.MySQLManager.toJavaType(MySQLManager.java:237) > at org.apache.sqoop.orm.ClassWriter.toJavaType(ClassWriter.java:253) > at org.apache.sqoop.orm.ClassWriter.generateFields(ClassWriter.java:480) > at > org.apache.sqoop.orm.ClassWriter.generateClassForColumns(ClassWriter.java:1306) > at org.apache.sqoop.orm.ClassWriter.generate(ClassWriter.java:1138) > at org.apache.sqoop.tool.CodeGenTool.generateORM(CodeGenTool.java:82) > at org.apache.sqoop.tool.ImportTool.importTable(ImportTool.java:390) > at > org.apache.sqoop.tool.ImportAllTablesTool.run(ImportAllTablesTool.java:64) > at org.apache.sqoop.Sqoop.run(Sqoop.java:145) > at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:69) > at org.apache.sqoop.Sqoop.runSqoop(Sqoop.java:181) > at org.apache.sqoop.Sqoop.runTool(Sqoop.java:220) > at org.apache.sqoop.Sqoop.runTool(Sqoop.java:229) > at org.apache.sqoop.Sqoop.main(Sqoop.java:238) > at com.cloudera.sqoop.Sqoop.main(Sqoop.java:57) > {noformat} > I have not tested with other connectors. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira