[
https://issues.apache.org/jira/browse/SQOOP-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250240#comment-13250240
]
[email protected] commented on SQOOP-467:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4641/
-----------------------------------------------------------
(Updated 2012-04-09 22:13:15.609452)
Review request for Sqoop.
Changes
-------
Use column type name strings instead of reflection to handle DB-specific types.
Summary (updated)
-------
Sqoop import does not support BINARY_FLOAT and BINARY_DOUBLE for Oracle db.
The changes include:
1) Add 3 methods to SqlManager class: toDbSpecificJavaType(),
toDbSpecificHiveType(), and toDbSpecificAvroType().
2) Override these methods in OracleManager to identify Oracle-specific types
based on their type name strings.
3) Eliminate uses of reflection from OracleManager.
4) Factor out special handling for "YEAR" in MySQLManager into a separate
method: fixupSqlType().
5) Add unit tests to OracleCompatTest for BINARY_FLOAT and BINARY_DOUBLE.
Note that Hive/Avro support for BINARY_FLOAT and BINARY_DOUBLE is not added
here. It will be implemented in the future.
This addresses bug SQOOP-467.
https://issues.apache.org/jira/browse/SQOOP-467
Diffs (updated)
-----
/src/java/org/apache/sqoop/manager/MySQLManager.java 1310648
/src/java/org/apache/sqoop/manager/OracleManager.java 1310648
/src/java/org/apache/sqoop/manager/SqlManager.java 1310648
/src/test/com/cloudera/sqoop/manager/OracleCompatTest.java 1310648
Diff: https://reviews.apache.org/r/4641/diff
Testing
-------
1) Verified with Oracle XE 10g that new tests pass.
2) Ran ant test, ant test -Dthirdparty=true, and ant checkstyle.
Thanks,
Cheolsoo
> Add support for Oracle BINARY_FLOAT and BINARY_DOUBLE data types
> ----------------------------------------------------------------
>
> Key: SQOOP-467
> URL: https://issues.apache.org/jira/browse/SQOOP-467
> Project: Sqoop
> Issue Type: Improvement
> Components: connectors
> Affects Versions: 1.4.1-incubating
> Reporter: Prashant Gokhale
> Assignee: Cheolsoo Park
>
> I get this error when I try to run import from Oracle table which has columns
> of type BINARY_FLOAT and BINARY_DOUBLE.
> {noformat}
> 12/03/23 11:19:05 ERROR orm.ClassWriter: Cannot resolve SQL type 100
> 12/03/23 11:19:05 ERROR orm.ClassWriter: Cannot resolve SQL type 101
> 12/03/23 11:19:05 ERROR orm.ClassWriter: No Java type for SQL type 100 for
> column B
> 12/03/23 11:19:05 ERROR orm.ClassWriter: No Java type for SQL type 101 for
> column C
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
