> On July 26, 2012, 9:13 p.m., Jarek Cecho wrote: > > /src/java/org/apache/sqoop/mapreduce/AutoProgressReducer.java, lines 34-35 > > <https://reviews.apache.org/r/2724/diff/3/?file=129304#file129304line34> > > > > I've notice that this class is to very hight extent identical to > > Sqoop's AutoProgressMapper. I'm thinking that rather then keeping similar > > code base twice, it might be beneficial to abstract shared functionality to > > separate class and simply reuse it in both AutoProgress[Mapper|Reducer]. > > What do you think?
I am going to get ProgressThread out of AutoProgressMapper and use it from both of AutoProgress[Mapper|Reducer] to remove duplicate code. - Masatake ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2724/#review9514 ----------------------------------------------------------- On July 26, 2012, 10:41 a.m., Masatake Iwasaki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2724/ > ----------------------------------------------------------- > > (Updated July 26, 2012, 10:41 a.m.) > > > Review request for Sqoop. > > > Description > ------- > > Patch for SQOOP-390 > https://issues.apache.org/jira/browse/SQOOP-390 > > > This addresses bug SQOOP-390. > https://issues.apache.org/jira/browse/SQOOP-390 > > > Diffs > ----- > > /src/java/org/apache/sqoop/manager/PGBulkloadManager.java PRE-CREATION > /src/java/org/apache/sqoop/mapreduce/AutoProgressReducer.java PRE-CREATION > /src/java/org/apache/sqoop/mapreduce/PGBulkloadExportJob.java PRE-CREATION > /src/java/org/apache/sqoop/mapreduce/PGBulkloadExportMapper.java > PRE-CREATION > /src/java/org/apache/sqoop/mapreduce/PGBulkloadExportReducer.java > PRE-CREATION > /src/test/com/cloudera/sqoop/manager/PGBulkloadManagerManualTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/2724/diff/ > > > Testing > ------- > > This patch include the test class PGBulkloadManagerTest. > I've tested "ant test" and passed. > > > Thanks, > > Masatake Iwasaki > >
