-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6630/
-----------------------------------------------------------
(Updated Aug. 22, 2012, 5:28 a.m.)
Review request for Sqoop and Bilung Lee.
Changes
-------
I've rebased my patch on current trunk and verified that is working.
Description
-------
This patch consists of two parts:
* Moving original MConnection and MJob structures to classes MConnectionForms
and MJobForms and creating standalone MConnection and MJob structures that
represents entire connection or job (e.g. for connection, MConnection wraps two
MConnectionForms structures - one for connector and second for framework part).
* Proposing new methods to repository interface for CRUD on new MConnection
objects
This addresses bug SQOOP-497.
https://issues.apache.org/jira/browse/SQOOP-497
Diffs (updated)
-----
/branches/sqoop2/client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java
1375901
/branches/sqoop2/common/src/main/java/org/apache/sqoop/json/ConnectorBean.java
1375901
/branches/sqoop2/common/src/main/java/org/apache/sqoop/model/MConnection.java
1373275
/branches/sqoop2/common/src/main/java/org/apache/sqoop/model/MConnectionForms.java
PRE-CREATION
/branches/sqoop2/common/src/main/java/org/apache/sqoop/model/MConnector.java
1375901
/branches/sqoop2/common/src/main/java/org/apache/sqoop/model/MFramework.java
1375901
/branches/sqoop2/common/src/main/java/org/apache/sqoop/model/MJob.java
1373275
/branches/sqoop2/common/src/main/java/org/apache/sqoop/model/MJobForms.java
PRE-CREATION
/branches/sqoop2/common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java
1375901
/branches/sqoop2/common/src/test/java/org/apache/sqoop/model/TestMFramework.java
1373275
/branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java
1375901
/branches/sqoop2/connector/connector-mysql-jdbc/src/main/java/org/apache/sqoop/connector/mysqljdbc/MySqlJdbcConnector.java
1375901
/branches/sqoop2/core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java
1375901
/branches/sqoop2/core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java
1375901
/branches/sqoop2/core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java
1375901
/branches/sqoop2/core/src/main/java/org/apache/sqoop/repository/Repository.java
1375901
/branches/sqoop2/repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
1375901
/branches/sqoop2/spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java
1375901
Diff: https://reviews.apache.org/r/6630/diff/
Testing
-------
Manual testing done, no new unit tests included.
Thanks,
Jarek Cecho
