[ 
https://issues.apache.org/jira/browse/SQOOP-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484402#comment-13484402
 ] 

Jarek Jarcec Cecho commented on SQOOP-651:
------------------------------------------

Hi Raja,
thank you for your patch. The changes (after reading documentation) seems 
reasonable to me. I just have one question - shouldn't we set *.jar to binary 
as we're having some of them in the repository?

Jarcec
                
> adding .gitattributes to prevent CRLF and LF mismatches for source and text 
> files
> ---------------------------------------------------------------------------------
>
>                 Key: SQOOP-651
>                 URL: https://issues.apache.org/jira/browse/SQOOP-651
>             Project: Sqoop
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 1.4.2, 2.0.0
>            Reporter: Raja Aluri
>         Attachments: SQOOP-651.patch
>
>
> With development happening on windows there is a higher chance of more CRLF 
> files getting into the source tree.
> I would like to avoid that by creating .gitattributes file which prevents 
> sources from having CRLF entries in text files.
> I am adding a couple of links here to give more primer on what exactly is the 
> issue and how we are trying to fix it.
> # http://git-scm.com/docs/gitattributes#_checking_out_and_checking_in
> # 
> http://stackoverflow.com/questions/170961/whats-the-best-crlf-handling-strategy-with-git
>  
> This issue for adding .gitattributes file to the tree.
> Please refer to 
> [HADOOP=8912|https://issues.apache.org/jira/browse/HADOOP-8912]

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to