-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9493/#review16710
-----------------------------------------------------------


Hi Linden,
thank you very much for putting this together. I believe that it might be quite 
helpful for Sqoop users. Some high level notes:

1) Can you change escaping of keywords and driver names from double quotes to 
"+"? It should be typeset as a keyword in generated document and I believe that 
it will result in more readable text.

2) I'm not sure that usage of --driver keyword will lead to the same exception 
in all connectors. I would recommend to only mention that --driver parameter 
will force Sqoop to use generic jdbc connector instead of the special one which 
might lead to performance issues and/or errors in the processing.

Jarcec

- Jarek Cecho


On Feb. 18, 2013, 3:17 p.m., Linden Hillenbrand wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9493/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2013, 3:17 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> Correcting Sqoop user-guide troubleshooting section to add verbage to make 
> sure users are aware that '--driver' flag should not be used with connection 
> managers as it will default to the default connection manager if that flag is 
> set.
> 
> 
> This addresses bug Sqoop-626.
>     https://issues.apache.org/jira/browse/Sqoop-626
> 
> 
> Diffs
> -----
> 
>   src/docs/user/troubleshooting.txt be43541 
> 
> Diff: https://reviews.apache.org/r/9493/diff/
> 
> 
> Testing
> -------
> 
> Standard tests run, docs built successfully.
> 
> 
> Thanks,
> 
> Linden Hillenbrand
> 
>

Reply via email to