----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9961/ -----------------------------------------------------------
Review request for Sqoop. Description ------- Allow Sqoop to build on Windows OS Associated Jira: https://issues.apache.org/jira/browse/SQOOP-949 Sqoop fails to build on Windows due to dependencies on Linux scripts like write-version-info.sh and create-tool-scripts.sh which fail to build on Windows without Cygwin. The patch does the following: - provide Windows scripts src/scripts/create-tool-scripts.cmd and src/scripts/write-version-info.cmd which perform the same logic as the .sh scripts on Linux. - Update build.xml to invoke the appropriate script based on the host OS. - Skip real-docs target on Windows OS builds since as it invokes Linux specific "make" executable This addresses bug SQOOP-949. https://issues.apache.org/jira/browse/SQOOP-949 Diffs ----- build.xml c097fe8 src/scripts/create-tool-scripts.cmd PRE-CREATION src/scripts/tool-script.cmd.template PRE-CREATION src/scripts/write-version-info.cmd PRE-CREATION Diff: https://reviews.apache.org/r/9961/diff/ Testing ------- Verified builds are successful on both Linux and Windows, and Unit tests are fully passing on Linux. Fixes to unit tests on Windows will go in a separate patch Thanks, Ahmed El Baz
