----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9771/ -----------------------------------------------------------
(Updated March 19, 2013, 8:30 a.m.) Review request for Sqoop and Jarek Cecho. Changes ------- Incorporating review comments from Jarek. Thanks again for your valuable time. I did reword the help and also took care of the return statement. Description ------- An attempt to add a way for users to pass credentials to sqoop in a secure way by storing the password in a file under user's home directory with 400 permissions. This addresses bug https://issues.apache.org/jira/browse/SQOOP-914. https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SQOOP-914 Diffs (updated) ----- src/docs/man/common-args.txt cf9c0c3 src/docs/user/common-args.txt 0554f81 src/docs/user/connecting.txt 44a5111 src/docs/user/help.txt 24fbddc src/docs/user/tools.txt 96bf777 src/java/org/apache/sqoop/SqoopOptions.java addc889 src/java/org/apache/sqoop/mapreduce/db/DBConfiguration.java d270bc8 src/java/org/apache/sqoop/tool/BaseSqoopTool.java 684d4a5 src/java/org/apache/sqoop/util/CredentialsUtil.java PRE-CREATION src/test/org/apache/sqoop/credentials/TestPassingSecurePassword.java PRE-CREATION Diff: https://reviews.apache.org/r/9771/diff/ Testing ------- Adds unit tests. All unit tests pass and checkstyle issues fixed. Thanks, Seetharam Venkatesh
