[ 
https://issues.apache.org/jira/browse/SQOOP-659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13616686#comment-13616686
 ] 

Jarek Jarcec Cecho commented on SQOOP-659:
------------------------------------------

Hi [~hshreedharan],
thank you very much for taking this JIRA. I appreciate your time and effort. 
I've read the document and I like suggested approach. Please go ahead with the 
implementation. I do have just one minor suggestion, I would recommend changing 
the {{Upgrader}} methods to:

{code}
public upgrade(MConnection old, MConnection new);
public upgrade(MJob old, MJon new);
{code}

The main difference here is that in this case the {{Upgraded}} is responsible 
only for moving the values specified by user (parameters, metadata) from one 
metadata structure to another whereas in the previous case it was also 
responsible for creating the structure itself. 

Jarcec
                
> Design metadata upgrade procedure
> ---------------------------------
>
>                 Key: SQOOP-659
>                 URL: https://issues.apache.org/jira/browse/SQOOP-659
>             Project: Sqoop
>          Issue Type: Task
>    Affects Versions: 2.0.0
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Hari Shreedharan
>            Priority: Blocker
>             Fix For: 2.0.0
>
>         Attachments: SqoopMetadataUpgrade.pdf, SqoopMetadataUpgrade.pdf
>
>
> We need to have procedure for metadata upgrade in place before first release.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to