-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10203/
-----------------------------------------------------------

(Updated March 30, 2013, 8:55 p.m.)


Review request for Sqoop.


Changes
-------

I've changed the resource variable name to "WEBAPP" to be consistent with rest 
of the Shell.


Description
-------

I've created environmental variables that will be fetched for Sqoop2 server 
default hostname (port, ...). Please note that resource file (if it exists) 
will have precedence over the environmental variables in current implementation.


This addresses bug SQOOP-972.
    https://issues.apache.org/jira/browse/SQOOP-972


Diffs (updated)
-----

  client/src/main/java/org/apache/sqoop/client/core/Constants.java 
cc956d0f9306a08ef9084e7b878f82e3e355d617 
  client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java 
25ae364641c7a03e8394ac14991370fc6f810745 

Diff: https://reviews.apache.org/r/10203/diff/


Testing
-------

I've done manual testing as we currently do not have tests for shell component.


Thanks,

Jarek Cecho

Reply via email to