> On April 12, 2013, 3:07 p.m., Jarek Cecho wrote: > > Hi Hari, > > thank you very much for working on this big JIRA. Your effort is greatly > > appreciated. It seems that current patch is implementing the work of > > upgrading the metadata structures in the Derby repository. As we are going > > to have much more repository implementations in the future, I think that it > > would be beneficial to abstract this behaviour from the repository and put > > the code to core module instead. This way we can be sure that the upgrade > > process will be the same for across all repositories. What do you think > > about that? > > > > Jarcec
Usually I prefer to keep implementations in the implementation class, but I guess this one can be moved up without much of an issue since we simply use other abstract methods from the same class which the child class must implement. - Hari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10281/#review19074 ----------------------------------------------------------- On April 4, 2013, 4:29 a.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10281/ > ----------------------------------------------------------- > > (Updated April 4, 2013, 4:29 a.m.) > > > Review request for Sqoop. > > > Description > ------- > > Metadata upgrade for connector upgrades. This is an initial patch soliciting > feedback. Limited testing has been done. I will add some unit tests once I > get feedback. > > > This addresses bug SQOOP-659. > https://issues.apache.org/jira/browse/SQOOP-659 > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/model/MConnection.java 36dca42 > common/src/main/java/org/apache/sqoop/model/MJob.java a53f04e > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java > c315e48 > core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 32df1e5 > core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java > ca51313 > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > 486635d > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java > ea458ac > spi/src/main/java/org/apache/sqoop/connector/spi/MetadataUpgrader.java > PRE-CREATION > spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java > 540303a > > Diff: https://reviews.apache.org/r/10281/diff/ > > > Testing > ------- > > > Thanks, > > Hari Shreedharan > >
