----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10943/#review20173 -----------------------------------------------------------
Hi Venkat, good catch! I have just two nits: src/java/org/apache/sqoop/manager/OracleManager.java <https://reviews.apache.org/r/10943/#comment41410> Do you think that we can use StringUtils.join(collection, ",") instead of the "Arrays.toString()? src/java/org/apache/sqoop/manager/SqlManager.java <https://reviews.apache.org/r/10943/#comment41409> Do you think that we can use StringUtils.join(collection, ",") instead of the "Arrays.toString()? Jarcec - Jarek Cecho On May 4, 2013, 11:54 p.m., Venkat Ranganathan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10943/ > ----------------------------------------------------------- > > (Updated May 4, 2013, 11:54 p.m.) > > > Review request for Sqoop and Jarek Cecho. > > > Description > ------- > > Provides an overridden implementation to get column names and types that > obeys the way Oracle DBMetadata provides procedure metadata > > > Diffs > ----- > > src/java/org/apache/sqoop/manager/OracleManager.java 1999344 > src/java/org/apache/sqoop/manager/SqlManager.java 6952b9e > > Diff: https://reviews.apache.org/r/10943/diff/ > > > Testing > ------- > > Tested with Oracle 11g > > > Thanks, > > Venkat Ranganathan > >
