----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10987/#review20855 -----------------------------------------------------------
Almost ready! Thanks for the update. I think it would be good to use the logger to log the messages and stack traces (should be under debug level). I have not marked all occurrences but I think you get the idea. Thanks Venkat src/test/org/apache/sqoop/manager/ManagerCompatExport.java <https://reviews.apache.org/r/10987/#comment42962> Can this be done as part of setUP? src/test/org/apache/sqoop/manager/SQLServerWhereManualTest.java <https://reviews.apache.org/r/10987/#comment42963> I think it would be good to push all the printStackTrace under LOG.debug and use the logger to capture the stacktrace. You can provide a stringified stack trace if you think the logger is truncating your stack trace. - Venkat Ranganathan On May 16, 2013, 6:48 p.m., Shuaishuai Nie wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10987/ > ----------------------------------------------------------- > > (Updated May 16, 2013, 6:48 p.m.) > > > Review request for Sqoop. > > > Description > ------- > > Add the MS Sqoop connector tests that test integration scenarios with SQL > Server to the repo. > > > This addresses bug SQOOP-1035. > https://issues.apache.org/jira/browse/SQOOP-1035 > > > Diffs > ----- > > conf/MSTest.properties PRE-CREATION > src/test/com/cloudera/sqoop/hive/TestHiveImport.java 462ccf1 > src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java > 27860c2 > src/test/org/apache/sqoop/manager/MSSQLTestData.java PRE-CREATION > src/test/org/apache/sqoop/manager/MSSQLTestDataFileParser.java PRE-CREATION > src/test/org/apache/sqoop/manager/MSSQLTestUtils.java PRE-CREATION > src/test/org/apache/sqoop/manager/ManagerCompatExport.java PRE-CREATION > > src/test/org/apache/sqoop/manager/SQLServerDatatypeExportDelimitedFileManualTest.java > PRE-CREATION > > src/test/org/apache/sqoop/manager/SQLServerDatatypeExportSequenceFileManualTest.java > PRE-CREATION > > src/test/org/apache/sqoop/manager/SQLServerDatatypeImportDelimitedFileManualTest.java > PRE-CREATION > > src/test/org/apache/sqoop/manager/SQLServerDatatypeImportSequenceFileManualTest.java > PRE-CREATION > src/test/org/apache/sqoop/manager/SQLServerHiveImportManualTest.java > PRE-CREATION > src/test/org/apache/sqoop/manager/SQLServerManagerManualTest.java > PRE-CREATION > src/test/org/apache/sqoop/manager/SQLServerMultiColsManualTest.java > PRE-CREATION > src/test/org/apache/sqoop/manager/SQLServerMultiMapsManualTest.java > PRE-CREATION > src/test/org/apache/sqoop/manager/SQLServerParseMethodsManualTest.java > PRE-CREATION > src/test/org/apache/sqoop/manager/SQLServerQueryManualTest.java > PRE-CREATION > src/test/org/apache/sqoop/manager/SQLServerSplitByManualTest.java > PRE-CREATION > src/test/org/apache/sqoop/manager/SQLServerWhereManualTest.java > PRE-CREATION > testdata/DatatypeTestData-export-lite.txt PRE-CREATION > testdata/DatatypeTestData-import-lite.txt PRE-CREATION > > Diff: https://reviews.apache.org/r/10987/diff/ > > > Testing > ------- > > All tests passing after applying the patch > > > Thanks, > > Shuaishuai Nie > >
