----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10964/#review21085 -----------------------------------------------------------
Hi Abe, thank you very much for working on this! Greatly appreciated. Would you mind making the Mini cluster optional? I think that it would be beneficial to run the integration tests on real cluster for example during Bigtop release, so ability to turning off the minicluster would be really helpful. test/src/test/java/org/apache/sqoop/integration/TomcatTestCase.java <https://reviews.apache.org/r/10964/#comment43628> The mini cluster is currently using build/ directory for storing the HDFS data. This directory is not inside the "target" dir, so it's not cleaned up automatically and RAT is complaining about it. I think that we need to set the "test.build.data" property in order to force the MiniDFSCluster to store data somewhere else, something like: System.setProperty("test.build.data", tmpPath + "/minicluster"); test/src/test/java/org/apache/sqoop/integration/TomcatTestCase.java <https://reviews.apache.org/r/10964/#comment43626> Nit: Please do not use tabs, just two spaces. Jarcec - Jarek Cecho On May 8, 2013, 9:16 p.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10964/ > ----------------------------------------------------------- > > (Updated May 8, 2013, 9:16 p.m.) > > > Review request for Sqoop and Jarek Cecho. > > > Description > ------- > > commit ff7dba55a09dd7789a34136233000c625759e583 > Author: Abraham Elmahrek <[email protected]> > Date: Fri Apr 26 15:10:24 2013 -0700 > > SQOOP-927 Sqoop2: Integration: Mapreduce specific tests should be running > on MiniCluster > > Handle MiniDFSCluster and MiniMRClientCluster on own. > > Set yarn.application.classpath to get over classpath errors. > Set to use fair scheduler. > > :100644 100644 0abbb18... f09704b... M pom.xml > :100644 100644 6eb3184... a4c2a5b... M > test/src/test/java/org/apache/sqoop/integration/TomcatTestCase.java > :100644 100644 0f48a8b... 758c885... M > test/src/test/java/org/apache/sqoop/integration/server/VersionTest.java > > > This addresses bug SQOOP-927. > https://issues.apache.org/jira/browse/SQOOP-927 > > > Diffs > ----- > > pom.xml 0abbb18 > test/src/test/java/org/apache/sqoop/integration/TomcatTestCase.java 6eb3184 > > Diff: https://reviews.apache.org/r/10964/diff/ > > > Testing > ------- > > Ran integration tests. > > > Thanks, > > Abraham Elmahrek > >
