----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11952/#review22263 -----------------------------------------------------------
Hi Mengwei, thank you very much for incorporating my suggestions! Would you mind rebasing your patch against current HEAD of sqoop2 branch? It do not seem to be applying cleanly anymore. client/src/main/java/org/apache/sqoop/client/shell/ShowSubmissionFunction.java <https://reviews.apache.org/r/11952/#comment45733> The way other functions works is that --all and --jid are mutually exclusive. Here it seems that the "-all" parameter is used to get details, so maybe it would be worth to introduce a different parameter? (for example "--details"?) client/src/main/java/org/apache/sqoop/client/shell/ShowSubmissionFunction.java <https://reviews.apache.org/r/11952/#comment45734> It seems that we have the same code also in SubmissionStatusFunction, so I would propose to put it into SubmissionDisplayer util class and share it. common/src/main/java/org/apache/sqoop/json/SubmissionBean.java <https://reviews.apache.org/r/11952/#comment45738> Can we add new test into TestSubmissionBean that will transport multiple submissions to make sure that we won't regress from that in the future? core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java <https://reviews.apache.org/r/11952/#comment45737> Can we add here protective code that will verify that the job id is valid? Similarly as is in method findSubmissionLastForJob() for example. docs/src/site/sphinx/CommandLineClient.rst <https://reviews.apache.org/r/11952/#comment45735> The docs seems to be out of sync with the implemented functionality. Jarcec - Jarek Cecho On June 19, 2013, 6:59 p.m., Mengwei Ding wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11952/ > ----------------------------------------------------------- > > (Updated June 19, 2013, 6:59 p.m.) > > > Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek. > > > Description > ------- > > commit 2800218fb1e6336b635e6ae85071f344d4a8a3dd > Author: Mengwei Ding <mengwei.d...@cloudera.com> > Date: Tue Jun 18 15:43:25 2013 -0700 > > SQOOP-1088 Submission History API - Add both APIs and shell command > (`show submission`) > > :100644 100644 9c7b351... 4ca71a4... M > client/src/main/java/org/apache/sqoop/client/SqoopClient.java > :100644 100644 056fcc8... 1365113... M > client/src/main/java/org/apache/sqoop/client/core/Constants.java > :100644 100644 32d4ae1... f102c8f... M > client/src/main/java/org/apache/sqoop/client/request/SqoopRequests.java > :100644 100644 69edabb... bafb30f... M > client/src/main/java/org/apache/sqoop/client/request/SubmissionRequest.java > :100644 100644 e24a7e8... 4245717... M > client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java > :000000 100644 0000000... fc14929... A > client/src/main/java/org/apache/sqoop/client/shell/ShowSubmissionFunction.java > :100644 100644 b159757... 8a570a1... M > client/src/main/resources/client-resource.properties > :100644 100644 1ef72eb... 91f2007... M > common/src/main/java/org/apache/sqoop/json/SubmissionBean.java > :100644 100644 6ee9aa1... ba9e94c... M > common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java > :100644 100644 d42e34a... 277dfcd... M > core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java > :100644 100644 3d29ab5... 538def5... M > core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java > :100644 100644 21dd759... 666bfc1... M > core/src/main/java/org/apache/sqoop/repository/Repository.java > :100644 100644 073d547... a1f8263... M > docs/src/site/sphinx/CommandLineClient.rst > :100644 100644 327896c... 4455f48... M > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java > :100644 100644 45a0da4... 0ea7bac... M > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > :100644 100644 c8ce3aa... 7a9ce50... M > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java > :100644 100644 de9a24b... de4d723... M > server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java > > > This addresses bug SQOOP-1088. > https://issues.apache.org/jira/browse/SQOOP-1088 > > > Diffs > ----- > > client/src/main/java/org/apache/sqoop/client/SqoopClient.java 9c7b351 > client/src/main/java/org/apache/sqoop/client/core/Constants.java 056fcc8 > client/src/main/java/org/apache/sqoop/client/request/SqoopRequests.java > 32d4ae1 > client/src/main/java/org/apache/sqoop/client/request/SubmissionRequest.java > 69edabb > client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java e24a7e8 > > client/src/main/java/org/apache/sqoop/client/shell/ShowSubmissionFunction.java > PRE-CREATION > client/src/main/resources/client-resource.properties b159757 > common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 1ef72eb > common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 6ee9aa1 > core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d42e34a > core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java > 3d29ab5 > core/src/main/java/org/apache/sqoop/repository/Repository.java 21dd759 > docs/src/site/sphinx/CommandLineClient.rst 073d547 > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java > 327896c > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > 45a0da4 > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java > c8ce3aa > server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java > de9a24b > > Diff: https://reviews.apache.org/r/11952/diff/ > > > Testing > ------- > > Have done several tiny scale tests on my standalone virtual machine cluster. > > > Thanks, > > Mengwei Ding > >
