----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11920/#review22283 -----------------------------------------------------------
Ship it! Good job Mengwei, please upload your patch to the JIRA and I'll commit it. - Jarek Cecho On June 21, 2013, 8:42 p.m., Mengwei Ding wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11920/ > ----------------------------------------------------------- > > (Updated June 21, 2013, 8:42 p.m.) > > > Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek. > > > Description > ------- > > commit 8f40d46cf416979271058a21d45c328710608624 > Author: Jarek Jarcec Cecho <jar...@apache.org> > Date: Thu Jun 20 15:02:56 2013 -0700 > > SQOOP-971 Add dynamic reconfiguration ability to RepositoryManager, > ConnectorManager and FrameworkManager > > :100644 100644 500189a... 0540f6b... M > core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java > :100644 100644 f59d132... eb7c1dc... M > core/src/main/java/org/apache/sqoop/core/CoreError.java > :000000 100644 0000000... d25ce41... A > core/src/main/java/org/apache/sqoop/core/Reconfigurable.java > :100644 100644 deb24c9... 13bbfc2... M > core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java > :100644 100644 84896d6... 90bb327... M > core/src/main/java/org/apache/sqoop/core/SqoopServer.java > :100644 100644 145a2c1... a81306b... M > core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java > :000000 100644 0000000... 9e90cac... A > core/src/main/java/org/apache/sqoop/framework/JobManager.java > :100644 100644 3339c59... e709975... M > core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryProvider.java > :100644 100644 955306d... d35b080... M > core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java > :100644 100644 4ea52e9... 1ec6bdf... M > core/src/main/java/org/apache/sqoop/repository/RepositoryProvider.java > :100644 100644 de9a24b... b61a6d6... M > server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java > > > This addresses bug SQOOP-971. > https://issues.apache.org/jira/browse/SQOOP-971 > > > Diffs > ----- > > core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 500189a > core/src/main/java/org/apache/sqoop/core/CoreError.java f59d132 > core/src/main/java/org/apache/sqoop/core/Reconfigurable.java PRE-CREATION > core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java deb24c9 > core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java 704b809 > core/src/main/java/org/apache/sqoop/framework/JobManager.java fd9aac9 > core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryProvider.java > 3339c59 > core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java > 955306d > core/src/main/java/org/apache/sqoop/repository/RepositoryProvider.java > 4ea52e9 > server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java > 1c40fc1 > > Diff: https://reviews.apache.org/r/11920/diff/ > > > Testing > ------- > > > Thanks, > > Mengwei Ding > >
