----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11911/#review22298 -----------------------------------------------------------
Ship it! Ship It! - Kathleen Ting On June 17, 2013, 4:34 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11911/ > ----------------------------------------------------------- > > (Updated June 17, 2013, 4:34 p.m.) > > > Review request for Sqoop. > > > Description > ------- > > I've cut the interesting methods into standalone packages/classes, so that > any third party code can easily reuse them. I've also moved the test cases > into the src package, so they can also be easily reused. The test package is > currently used only for the integration tests themselves. > > > This addresses bug SQOOP-1087. > https://issues.apache.org/jira/browse/SQOOP-1087 > > > Diffs > ----- > > test/pom.xml b7ea1ed5716d082239eed98849fb4ca1c4d6e4a4 > test/src/main/java/org/apache/sqoop/test/asserts/HdfsAsserts.java > PRE-CREATION > test/src/main/java/org/apache/sqoop/test/asserts/ProviderAsserts.java > PRE-CREATION > test/src/main/java/org/apache/sqoop/test/data/Cities.java PRE-CREATION > test/src/main/java/org/apache/sqoop/test/data/DataSet.java PRE-CREATION > test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java > PRE-CREATION > test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java > PRE-CREATION > test/src/main/java/org/apache/sqoop/test/utils/HdfsUtils.java PRE-CREATION > test/src/test/java/org/apache/sqoop/integration/TomcatTestCase.java > fa2c2b467d3a252ff54728762a7e96fbb4fbc9af > > test/src/test/java/org/apache/sqoop/integration/connector/ConnectorTestCase.java > d4e432de12e7768bc0b111e7e5942b8f22edd7a1 > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableExportTest.java > b920655ef46902d1c937748f9b78e3f1b491ebf3 > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableImportTest.java > adcfbaf895586a216f196380176dcae25017e646 > test/src/test/java/org/apache/sqoop/integration/server/VersionTest.java > 0f48a8b6fe7b94e32e5a894bd33b653c6f6d1583 > > Diff: https://reviews.apache.org/r/11911/diff/ > > > Testing > ------- > > Integration tests are passing. > > > Thanks, > > Jarek Cecho > >
