> On July 24, 2013, 2:07 a.m., Jarek Cecho wrote: > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java, > > line 256 > > <https://reviews.apache.org/r/12593/diff/4/?file=323592#file323592line256> > > > > This change is not backward compatible. We need to ensure that the > > upgrade process will be correct. I would suggest you to take a look into > > method DerbyRepositoryHandler.createOrUpdateInternals().
Yes, already figure out this problem as I did for SQOOP-1142 - Mengwei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12593/#review23727 ----------------------------------------------------------- On July 18, 2013, 11:58 p.m., Mengwei Ding wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12593/ > ----------------------------------------------------------- > > (Updated July 18, 2013, 11:58 p.m.) > > > Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho. > > > Bugs: SQOOP-1141 > https://issues.apache.org/jira/browse/SQOOP-1141 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > commit ba552918976799d7b7877dc31371274c6a4ba733 > Author: Mengwei Ding <mengwei.d...@gmail.com> > Date: Tue Jul 16 10:41:12 2013 -0700 > > SQOOP-1141 Sqoop2: Provide ability to enable/disable connections and jobs > > :100644 100644 4ca71a4... 158e46c... M > client/src/main/java/org/apache/sqoop/client/SqoopClient.java > :100644 100644 b7b0436... 999790d... M > client/src/main/java/org/apache/sqoop/client/core/Constants.java > :100644 100644 a69e009... cb7af2e... M > client/src/main/java/org/apache/sqoop/client/request/ConnectionRequest.java > :100644 100644 55ba9db... 77f1341... M > client/src/main/java/org/apache/sqoop/client/request/JobRequest.java > :100644 100644 f102c8f... ffaa84f... M > client/src/main/java/org/apache/sqoop/client/request/SqoopRequests.java > :000000 100644 0000000... 5cbd6db... A > client/src/main/java/org/apache/sqoop/client/shell/DisableCommand.java > :000000 100644 0000000... e04292a... A > client/src/main/java/org/apache/sqoop/client/shell/DisableConnectionFunction.java > :000000 100644 0000000... 5962cd2... A > client/src/main/java/org/apache/sqoop/client/shell/DisableJobFunction.java > :000000 100644 0000000... 8a2c1c7... A > client/src/main/java/org/apache/sqoop/client/shell/EnableCommand.java > :000000 100644 0000000... ed6dc3c... A > client/src/main/java/org/apache/sqoop/client/shell/EnableConnectionFunction.java > :000000 100644 0000000... 9e4e320... A > client/src/main/java/org/apache/sqoop/client/shell/EnableJobFunction.java > :100644 100644 32bca71... 94f92b3... M > client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java > :100644 100644 590e4e7... 97a240b... M > client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java > :100644 100644 aa87f20... f4ea3be... M > client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java > :100644 100644 5537a8e... 1a8f963... M > client/src/main/resources/client-resource.properties > :100644 100644 b4e986a... a014ddd... M > common/src/main/java/org/apache/sqoop/json/ConnectionBean.java > :100644 100644 a830646... 4685797... M > common/src/main/java/org/apache/sqoop/json/JobBean.java > :100644 100644 98768d6... ba12b39... M > common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java > :100644 100644 137e71c... 5524983... M > common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java > :100644 100644 dd1d75b... 2f2b974... M > common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java > :100644 100644 6af1d8b... e42b7df... M > common/src/test/java/org/apache/sqoop/json/TestJobBean.java > :100644 100644 4ea42b1... bf103e4... M > common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java > :100644 100644 4277311... f7a6b67... M > core/src/main/java/org/apache/sqoop/framework/FrameworkError.java > :100644 100644 9f09982... d0a087d... M > core/src/main/java/org/apache/sqoop/framework/JobManager.java > :100644 100644 095f3e9... 7768b13... M > core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java > :100644 100644 d468b79... 9299484... M > core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java > :100644 100644 92e11d2... 7c7673f... M > core/src/main/java/org/apache/sqoop/repository/Repository.java > :100644 100644 aeb7533... 455eb64... M > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java > :100644 100644 f717abf... d7a3ad1... M > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > :100644 100644 68cb1c0... 49bf607... M > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java > :100644 100644 b2cd6cc... 4c7a656... M > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java > :100644 100644 8266b46... 6959f2d... M > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectionHandling.java > :100644 100644 4c97e1e... a3d804e... M > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java > :100644 100644 038f602... ab4dfd5... M > server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java > :100644 100644 ab3f9d0... 4988d97... M > server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java > > > Diffs > ----- > > client/src/main/java/org/apache/sqoop/client/SqoopClient.java 4ca71a4 > client/src/main/java/org/apache/sqoop/client/core/Constants.java b7b0436 > client/src/main/java/org/apache/sqoop/client/request/ConnectionRequest.java > a69e009 > client/src/main/java/org/apache/sqoop/client/request/JobRequest.java > 55ba9db > client/src/main/java/org/apache/sqoop/client/request/SqoopRequests.java > f102c8f > client/src/main/java/org/apache/sqoop/client/shell/DisableCommand.java > PRE-CREATION > > client/src/main/java/org/apache/sqoop/client/shell/DisableConnectionFunction.java > PRE-CREATION > client/src/main/java/org/apache/sqoop/client/shell/DisableJobFunction.java > PRE-CREATION > client/src/main/java/org/apache/sqoop/client/shell/EnableCommand.java > PRE-CREATION > > client/src/main/java/org/apache/sqoop/client/shell/EnableConnectionFunction.java > PRE-CREATION > client/src/main/java/org/apache/sqoop/client/shell/EnableJobFunction.java > PRE-CREATION > > client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java > 32bca71 > client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java > 590e4e7 > client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java aa87f20 > client/src/main/resources/client-resource.properties 5537a8e > common/src/main/java/org/apache/sqoop/json/ConnectionBean.java b4e986a > common/src/main/java/org/apache/sqoop/json/JobBean.java a830646 > common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java > 98768d6 > common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java 137e71c > common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java dd1d75b > common/src/test/java/org/apache/sqoop/json/TestJobBean.java 6af1d8b > common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java > 4ea42b1 > core/src/main/java/org/apache/sqoop/framework/FrameworkError.java 4277311 > core/src/main/java/org/apache/sqoop/framework/JobManager.java 9f09982 > core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 095f3e9 > core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java > d468b79 > core/src/main/java/org/apache/sqoop/repository/Repository.java 92e11d2 > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java > aeb7533 > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > f717abf > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java > 68cb1c0 > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java > b2cd6cc > > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectionHandling.java > 8266b46 > > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java > 4c97e1e > server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java > 038f602 > server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java > ab3f9d0 > > Diff: https://reviews.apache.org/r/12593/diff/ > > > Testing > ------- > > Did some manual tests to check whether job could be started if either job or > connection has been disabled. > > > Thanks, > > Mengwei Ding > >
