----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12821/#review23993 -----------------------------------------------------------
Hi Abe, thank you very much for working on this JIRA, I do have two comments: common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java <https://reviews.apache.org/r/12821/#comment47808> Nit: Unused import. common/src/main/java/org/apache/sqoop/json/util/SerializationError.java <https://reviews.apache.org/r/12821/#comment47809> This file seems to be missing the license header. Jarcec - Jarek Cecho On July 23, 2013, 12:10 a.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12821/ > ----------------------------------------------------------- > > (Updated July 23, 2013, 12:10 a.m.) > > > Review request for Sqoop, Hari Shreedharan and Jarek Cecho. > > > Bugs: SQOOP-1145 > https://issues.apache.org/jira/browse/SQOOP-1145 > > > Repository: sqoop-trunk > > > Description > ------- > > commit 1b2cb874b7ddd2d58b95cd1edfc1125f09892977 > Author: Abraham Elmahrek <[email protected]> > Date: Mon Jul 22 16:53:45 2013 -0700 > > SQOOP-1145 Sqoop2: Use JSON object for serializing MAP input type > > :100644 100644 98768d6... 50836b6... M > common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java > :000000 100644 0000000... bbae9a0... A > common/src/main/java/org/apache/sqoop/json/util/SerializationError.java > :100644 100644 27db8af... e0c7977... M > common/src/main/java/org/apache/sqoop/model/FormUtils.java > :100644 100644 98a70f1... bbfd33d... M > common/src/test/java/org/apache/sqoop/json/util/TestFormSerialization.java > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java > 98768d6cd0db3a7b5b1ac42fce557f52375461ab > common/src/main/java/org/apache/sqoop/json/util/SerializationError.java > PRE-CREATION > common/src/main/java/org/apache/sqoop/model/FormUtils.java > 27db8af30f8cd9098ad54d0984b428e0b2dff0ce > common/src/test/java/org/apache/sqoop/json/util/TestFormSerialization.java > 98a70f1dc2f99e60c2919893beef0a5b21d761f8 > > Diff: https://reviews.apache.org/r/12821/diff/ > > > Testing > ------- > > Ran sqoop tests > > > Thanks, > > Abraham Elmahrek > >
