> On Aug. 19, 2013, 12:54 a.m., Jarek Cecho wrote: > > Would you mind rebasing the patch on current head of sqoop2 branch? We've > > recently moved the client code to a Shell package so the patch do not > > longer applies cleanly.
Yes, definitely. - Mengwei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13273/#review25285 ----------------------------------------------------------- On Aug. 5, 2013, 6:10 p.m., Mengwei Ding wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13273/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2013, 6:10 p.m.) > > > Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho. > > > Bugs: SQOOP-1162 > https://issues.apache.org/jira/browse/SQOOP-1162 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > commit 64ebb185e42578ec0138639780e4953e22d4cff9 > Author: Mengwei Ding <mengwei.d...@gmail.com> > Date: Mon Aug 5 10:47:29 2013 -0700 > > SQOOP-1162: Sqoop2: 'show option' should have help entry showing that > 'all' arg can be used > > :100644 100644 999790d... 7ebd4d3... M > client/src/main/java/org/apache/sqoop/client/core/Constants.java > :100644 100644 81c5612... 36b3ae8... M > client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java > :100644 100644 1a8f963... 610b6b2... M > client/src/main/resources/client-resource.properties > > > Diffs > ----- > > client/src/main/java/org/apache/sqoop/client/core/Constants.java 999790d > client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java > 81c5612 > client/src/main/resources/client-resource.properties 1a8f963 > > Diff: https://reviews.apache.org/r/13273/diff/ > > > Testing > ------- > > > Thanks, > > Mengwei Ding > >