Review Request 13942: SQOOP-1189 Sqoop2: Ensure that clone methods will correctly copy over all values from all parents

Tue, 03 Sep 2013 06:32:51 -0700 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13942/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-1189
    https://issues.apache.org/jira/browse/SQOOP-1189


Repository: sqoop-sqoop2


Description
-------

I've added couple of new constructors and make the clone methods of MJob and 
MConnection a bit simpler. I've also fixed the upgrade code to use the new 
methods to clone objects reliably.


Diffs
-----

  common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java 
8af7c15d34b6d54e7c74849f92ea25dd0122f347 
  common/src/main/java/org/apache/sqoop/model/MConnection.java 
0e4f1a2f499e507594532c3e62de0fb943f8e551 
  common/src/main/java/org/apache/sqoop/model/MJob.java 
c58d1f0d58cfbe1ae000f4cf8319e685271d12bb 
  common/src/main/java/org/apache/sqoop/model/MPersistableEntity.java 
01ecbfb63b50f88e9f37994df8b9ae868d7a97f4 
  common/src/test/java/org/apache/sqoop/model/TestMConnection.java 
301ef1de04b4b541e4e9d24a32309b9eb4c6d40f 
  common/src/test/java/org/apache/sqoop/model/TestMJob.java 
6cbf7a6baa15447725ffd5be8b7dedb0fbaefb5b 
  core/src/main/java/org/apache/sqoop/repository/Repository.java 
8bf0d406ce4b7a40630905693b475e72a545006a 

Diff: https://reviews.apache.org/r/13942/diff/


Testing
-------

I've refined current test cases to be a bit easier to read and added more 
features to be tested.


Thanks,

Jarek Cecho

Reply via email to