----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14240/#review26867 -----------------------------------------------------------
Indeed Alexandre, I believe we're very close to get it in! Thank you for all your effort! I've tested the patch on real cluster running HBase 0.94 and found one small issue noted below. I'll try to spin out HBase 0.95 to finish the testing on my side. src/java/org/apache/sqoop/mapreduce/HBaseBulkImportJob.java <https://reviews.apache.org/r/14240/#comment52249> The super.jobSetup() is handling the parameter --create-hbase-table, however we are expecting that the table exists here before the call to super.jobSetup(). As a result if the table do not exists (regardless whether the argument --create-hbase-table is present or not) exception org.apache.hadoop.hbase.TableNotFoundException will get thrown. I've moved the call the the begging of the method and it seems to be working for me. Jarcec - Jarek Cecho On Oct. 9, 2013, 11:53 p.m., Alexandre Normand wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14240/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2013, 11:53 p.m.) > > > Review request for Sqoop, Jarek Cecho, Jean-Marc Spaggiari, and Vasanth kumar > RJ. > > > Repository: sqoop-trunk > > > Description > ------- > > This is the patch to address some of the comments on Zhancheng Deng's review > request (https://reviews.apache.org/r/13052/) which was basically the change > to add the --bulk-load-dir option to support the HBase doBulkLoad function. > > > Diffs > ----- > > src/docs/user/hbase-args.txt 8ba23eb > src/docs/user/hbase.txt 34f9875 > src/java/org/apache/sqoop/SqoopOptions.java 01805f9 > src/java/org/apache/sqoop/hbase/HBasePutProcessor.java 9ceb5bd > src/java/org/apache/sqoop/hbase/ToStringPutTransformer.java 5ccf311 > src/java/org/apache/sqoop/manager/SqlManager.java 2a4992d > src/java/org/apache/sqoop/mapreduce/HBaseBulkImportJob.java PRE-CREATION > src/java/org/apache/sqoop/mapreduce/HBaseBulkImportMapper.java PRE-CREATION > src/java/org/apache/sqoop/mapreduce/ImportJobBase.java ab7f21e > src/java/org/apache/sqoop/tool/BaseSqoopTool.java 0eca991 > src/test/com/cloudera/sqoop/TestSqoopOptions.java 03e2504 > > Diff: https://reviews.apache.org/r/14240/diff/ > > > Testing > ------- > > > Thanks, > > Alexandre Normand > >
