-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14779/
-----------------------------------------------------------

(Updated Oct. 23, 2013, 2:22 a.m.)


Review request for Sqoop.


Changes
-------

Updates based on Jarcec's feedback.
 - Fixed whitespace to mirror Sqoop standard.
 - Added JUnit coverage to validate that the saved *.avsc file matches the 
Schema extracted from part-*.avro.
 - Added logic to move *.avsc file to code output directory, given that a file 
of the same name doesn't already exist.


Bugs: SQOOP-435
    https://issues.apache.org/jira/browse/SQOOP-435


Repository: sqoop-trunk


Description
-------

Automatically generate an Avro schema file (*.avsc) in the JAR output directory 
when --as-avrodatafile is specified.


Diffs (updated)
-----

  src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java 5afd90c 
  src/test/com/cloudera/sqoop/TestAvroImport.java 34a7d41 

Diff: https://reviews.apache.org/r/14779/diff/


Testing
-------

- Compared contents of *.avsc file against output from avro-tools getschema 
operation.
- Created an external Hive table with AvroSerDe, pointing avro.schema.url to a 
copy of the schema indexed in ElasticSearch.


Thanks,

James Anderson

Reply via email to