> On Nov. 2, 2013, 5:04 p.m., Sean Busbey wrote: > > src/java/org/apache/sqoop/accumulo/AccumuloMutationProcessor.java, lines > > 131-141 > > <https://reviews.apache.org/r/8559/diff/6/?file=373821#file373821line131> > > > > Just curious, is there a reason you went for throwing an error rather > > than using the equivalent of having EMPTY_BYTES for these, the way the > > convenience methods in Mutation (http://bit.ly/16VR93I) handle a missing > > visibility? > > Philip Grim wrote: > Do we really want to allow an import to a blank column family? Does > anyone do that? Does Accumulo even allow it? Personally, I don't see a use > case for it even if Accumulo did allow it. > > Similarly, how can we import data without setting which column in the > source data is the unique key? What would we do as the behavior? I suppose > a one-up or a hash of the fields or something, but again, I'm not sure of the > usefulness of that. > > Finally, I intended the behavior of this import to be consistent with the > behavior of the HBase import, which also requires these to be set (or at > least, they did when I first wrote this code a year ago).
consistent with existing HBase is good, and the current trunk still requires both. - Sean ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8559/#review28072 ----------------------------------------------------------- On Nov. 4, 2013, 11 p.m., Philip Grim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8559/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2013, 11 p.m.) > > > Review request for accumulo, Sqoop and Jarek Cecho. > > > Repository: sqoop-trunk > > > Description > ------- > > Adds the ability to import to an Accumulo table in much the same manner as > the current HBase import capability. Reported in JIRA as ACCUMULO-141 and > SQOOP-767. > > > Diffs > ----- > > ivy.xml c5130ae > src/docs/user/accumulo-args.txt PRE-CREATION > src/docs/user/accumulo.txt PRE-CREATION > src/java/org/apache/sqoop/SqoopOptions.java 13637b5 > src/java/org/apache/sqoop/accumulo/AccumuloMutationProcessor.java > PRE-CREATION > src/java/org/apache/sqoop/accumulo/AccumuloUtil.java PRE-CREATION > src/java/org/apache/sqoop/accumulo/MutationTransformer.java PRE-CREATION > src/java/org/apache/sqoop/accumulo/ToStringMutationTransformer.java > PRE-CREATION > src/java/org/apache/sqoop/manager/SqlManager.java 1ffa40f > src/java/org/apache/sqoop/mapreduce/AccumuloImportJob.java PRE-CREATION > src/java/org/apache/sqoop/mapreduce/AccumuloImportMapper.java PRE-CREATION > src/java/org/apache/sqoop/tool/BaseSqoopTool.java 9230f82 > src/java/org/apache/sqoop/tool/ImportTool.java fbbde1d > src/test/org/apache/sqoop/accumulo/AccumuloTestCase.java PRE-CREATION > src/test/org/apache/sqoop/accumulo/TestAccumuloImport.java PRE-CREATION > src/test/org/apache/sqoop/accumulo/TestAccumuloQueryImport.java > PRE-CREATION > src/test/org/apache/sqoop/accumulo/TestAccumuloUtil.java PRE-CREATION > > Diff: https://reviews.apache.org/r/8559/diff/ > > > Testing > ------- > > > Thanks, > > Philip Grim > >
