----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17820/#review33848 -----------------------------------------------------------
Ship it! Calling close multiple times shouldn't have any effect any ways... good stuff! - Abraham Elmahrek On Feb. 6, 2014, 8:57 p.m., Venkat Ranganathan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17820/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2014, 8:57 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1279 > https://issues.apache.org/jira/browse/SQOOP-1279 > > > Repository: sqoop-trunk > > > Description > ------- > > I tested the previous connection resiliency with Mysql Java connector 5.1.x. > But there are still users of 5.0.x. This is to fix backward compatibility > issues with mysql 5.0.8 java connector > > > Diffs > ----- > > src/java/org/apache/sqoop/mapreduce/db/DBRecordReader.java e33e427 > > Diff: https://reviews.apache.org/r/17820/diff/ > > > Testing > ------- > > Tested with Mysql connector for 5.0.x. Ran all tests > > > Thanks, > > Venkat Ranganathan > >
