So my issue of the automated tests failing only affects the test code which the customers will not be using.
So I'm +1 with releasing as is and just fixing this issue in the master branch. -----Original Message----- From: Abraham Elmahrek [mailto:a...@cloudera.com] Sent: Saturday, 9 August 2014 1:17 PM To: Jarek Jarcec Cecho Cc: dev@sqoop.apache.org Subject: Re: [VOTE] Release Sqoop version 1.4.5 It looks like we have 1 more open thread. Let's wait until Monday of next week (08/11/2014) to officially release. -Abe On Fri, Aug 8, 2014 at 2:52 PM, Abraham Elmahrek <a...@cloudera.com> wrote: > Hey guys, > > I've downloaded the tarballs, ran the tests, and performed the > following manual tests: > > - Import with MySQL, PostgreSQL, SQLServer, and Oracle to HDFS. > - Import with MySQL to HBase (create table as well). > - Export from HDFS to MySQL and PostgreSQL. > - Incremental import from MySQL to HDFS with append mode. > - Incremental import from MySQL to HDFS with lastmodified mode. > - Import from MySQL to avro. > - Import from MySQL to sequence file. > > Things seem in order. +1 from me. > > -Abe > > > On Fri, Aug 8, 2014 at 1:29 PM, Abraham Elmahrek <a...@cloudera.com> wrote: > >> David, >> >> I don't think that we should spin up a new RC candidate for this >> particular issue. The tests were not failing and any problems we run >> into with OraOop we can fall back onto the original oracle connector. >> Good find though! >> >> -Abe >> >> >> >> On Fri, Aug 8, 2014 at 9:23 AM, Jarek Jarcec Cecho >> <jar...@apache.org> >> wrote: >> >>> > One minor thing I noticed - Sqoop 1.4.4 doesn't have .gitignore >>> > and >>> .gitattributes files in the archive - but 1.4.5 does. I'm not sure >>> if this is intentional or not? >>> >>> Intentional: >>> >>> https://issues.apache.org/jira/browse/SQOOP-1268 >>> >>> Jarcec >>> >>> On Aug 7, 2014, at 8:00 PM, David Robson >>> <david.rob...@software.dell.com> >>> wrote: >>> >>> > I found an issue where the integration tests for the direct Oracle >>> connector weren't running as they didn't have the direct flag. I >>> raised >>> SQOOP-1422 and fixed this - then ran all the Oracle related tests >>> and they passed. >>> > >>> > Did a quick smoke test of a few Oracle imports / exports and they >>> > ran >>> fine. >>> > >>> > One minor thing I noticed - Sqoop 1.4.4 doesn't have .gitignore >>> > and >>> .gitattributes files in the archive - but 1.4.5 does. I'm not sure >>> if this is intentional or not? >>> > >>> > So looks good aside from those 2 minor issues - but we may not >>> > need to >>> address them in 1.4.5? >>> > >>> > -----Original Message----- >>> > From: Venkat Ranganathan [mailto:vranganat...@hortonworks.com] >>> > Sent: Thursday, 7 August 2014 3:36 PM >>> > To: dev@sqoop.apache.org >>> > Cc: a...@apache.org >>> > Subject: Re: [VOTE] Release Sqoop version 1.4.5 >>> > >>> > +1 >>> > >>> > Verifed checksums, built and ran tests >>> > >>> > Venkat >>> > >>> > On Wed, Aug 6, 2014 at 7:55 PM, Jarek Jarcec Cecho >>> > <jar...@apache.org> >>> wrote: >>> >> +1 >>> >> >>> >> * Verified checksums and signatures >>> >> * Run tests >>> >> * Verified top level files >>> >> >>> >> Jarcec >>> >> >>> >> On Aug 1, 2014, at 1:28 PM, Abraham Elmahrek <a...@apache.org> wrote: >>> >> >>> >>> This is the fourth release for Apache Sqoop 1, version 1.4.5. >>> >>> Please cast your vote by 08/08/2014! >>> >>> >>> >>> The list of fixed issues: >>> >>> >>> >>> * >>> https://git-wip-us.apache.org/repos/asf?p=sqoop.git;a=blob;f=CHANGEL >>> >>> OG.txt;h=859086a8d69bb2f51b77107001717b750631d318;hb=144cdff2127 >>> >>> edc3f >>> >>> a9f0e903671e5f4f8feccc27 >>> >>> < >>> https://git-wip-us.apache.org/repos/asf?p=sqoop.git;a=blob;f=CHANGEL >>> >>> OG.txt;h=859086a8d69bb2f51b77107001717b750631d318;hb=144cdff2127 >>> >>> edc3f >>> >>> a9f0e903671e5f4f8feccc27>* >>> >>> >>> >>> >>> >>> The tarball (*.tar.gz), signature (*.asc), checksum (*.md5): >>> >>> >>> >>> http://people.apache.org/~abe/sqoop/releases/1.4.5/rc0/ >>> >>> >>> >>> The tag to be voted upon: >>> >>> >>> https://git-wip-us.apache.org/repos/asf?p=sqoop.git;a=tag;h=refs/tag >>> s >>> >>> /release-1.4.5-rc0 >>> >>> >>> >>> The KEYS file: >>> >>> >>> >>> https://dist.apache.org/repos/dist/release/sqoop/KEYS >>> >>> >>> >>> Thanks,Abraham Elmahrek >>> >> >>> > >>> > -- >>> > CONFIDENTIALITY NOTICE >>> > NOTICE: This message is intended for the use of the individual or >>> entity to which it is addressed and may contain information that is >>> confidential, privileged and exempt from disclosure under applicable law. >>> If the reader of this message is not the intended recipient, you are >>> hereby notified that any printing, copying, dissemination, >>> distribution, disclosure or forwarding of this communication is >>> strictly prohibited. If you have received this communication in >>> error, please contact the sender immediately and delete it from your >>> system. Thank You. >>> >>> >> >