----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25072/#review51620 -----------------------------------------------------------
Ship it! Ship It! - Abraham Elmahrek On Aug. 26, 2014, 8:38 p.m., Venkat Ranganathan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25072/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2014, 8:38 p.m.) > > > Review request for Sqoop. > > > Repository: sqoop-trunk > > > Description > ------- > > We used StringUtils.repeat(String,String, int) in TestExportCallingProcedure > test. At that time, the ivy/libraries.properties was not updated to use > commons-lang:2.4, but still the tests passed becase the later version of > commons-lang was pulled in satisfying this. Since Hadoop 2.4.x, older > version of commona-lang without this method is getting pulled in. > > Changing the ivy/libraries.properties does not help. So, fixed the test to > not use the repeat method with three args > > > Diffs > ----- > > src/test/org/apache/sqoop/TestExportUsingProcedure.java 78d688d > > Diff: https://reviews.apache.org/r/25072/diff/ > > > Testing > ------- > > ant clean test -Dtestcase=TestExportUsingProcedure -Dhadoop.version=2.4.0 > passes with this change > > > Thanks, > > Venkat Ranganathan > >
