[
https://issues.apache.org/jira/browse/SQOOP-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Veena Basavaraj updated SQOOP-1584:
-----------------------------------
Description:
{code}
try {
LOG.info("Initializing the RepositoryManager with immutable option turned
off.");
RepositoryManager.getInstance().initialize(false);
{code}
can we simply remove the double negative ? and make the config as mutable =
true. Wont this make reading and understanding code much simpler?
was:
fix the upgrade logic for 1498 changes.
While fixing the upgrade logic, added comments on how the upgrade logic works.
-renamed test methods to reflect what they are upgrading and what they are
infact testing.
-renamed the internals to exactly mean "schema" upgrades, since we only allow/
do scheme upgrades the repository
-Also updated the names on the repository api to clearly state the difference
between upgrade and update operations on connector / driver.
> Sqoop2: Invert the double negative for repository upgrade
> ---------------------------------------------------------
>
> Key: SQOOP-1584
> URL: https://issues.apache.org/jira/browse/SQOOP-1584
> Project: Sqoop
> Issue Type: Improvement
> Reporter: Veena Basavaraj
> Assignee: Veena Basavaraj
>
> {code}
> try {
> LOG.info("Initializing the RepositoryManager with immutable option
> turned off.");
> RepositoryManager.getInstance().initialize(false);
> {code}
> can we simply remove the double negative ? and make the config as mutable =
> true. Wont this make reading and understanding code much simpler?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
