> On Oct. 15, 2014, 6:33 p.m., Abraham Elmahrek wrote: > > Great first crack at this! I have a couple of NITs below and a few design > > thoughts: > > 1. Will this be a Hadoop2 only mechanism? Or is there a follow up Jira for > > Hadoop1? > > 2. The AuthenticationManager seems to be an all-in-one singleton. In > > practice, this may work fine, but I'm concerned adding other forms of auth. > > might be difficult. Does it make any sense to add some abstractions to take > > care of the different authentication mechanisms and make it pluggable?
Thanks for your review and valuable comment. 1. It is just for Hadoop2 currently. I will create JIRA for Hadoop1 later. 2. This is a good suggestion. I will add an abstract class and factory for AuthenticationManager. > On Oct. 15, 2014, 6:33 p.m., Abraham Elmahrek wrote: > > core/src/main/java/org/apache/sqoop/authentication/AuthenticationManager.java, > > lines 59-68 > > <https://reviews.apache.org/r/26678/diff/1/?file=720393#file720393line59> > > > > Does it make sense to delegate this information to some other > > abstraction since we might not even use it? Do you mean move it to KerberosAuthenticationManager.java instead of abstract class AuthenticationManager.java? > On Oct. 15, 2014, 6:33 p.m., Abraham Elmahrek wrote: > > core/src/main/java/org/apache/sqoop/authentication/AuthenticationManager.java, > > line 109 > > <https://reviews.apache.org/r/26678/diff/1/?file=720393#file720393line109> > > > > Not sure if we should authenticate upon initialization of > > AuthenticationManager. How about making secureLogin public? I am not sure whether there is a better place to hold secureLogin. According to HDFS/YARN/HIVESERVER2, the secureLogin happens when initiating service (NameNode, DataNode, etc.). - richard ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26678/#review56759 ----------------------------------------------------------- On Oct. 14, 2014, 7:44 a.m., richard zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26678/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2014, 7:44 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Kerberos support when starting service > > > Diffs > ----- > > core/pom.xml 2b6e436d637eb03493323e5b36e31e433c1f8bbb > > core/src/main/java/org/apache/sqoop/authentication/AuthenticationConstants.java > PRE-CREATION > core/src/main/java/org/apache/sqoop/authentication/AuthenticationError.java > PRE-CREATION > > core/src/main/java/org/apache/sqoop/authentication/AuthenticationManager.java > PRE-CREATION > core/src/main/java/org/apache/sqoop/core/SqoopServer.java > ac836c7cee010144696ab17645ccd008aed5762d > dist/src/main/server/conf/sqoop.properties > bb010166120321899425f84edb8e1ad6512626d2 > pom.xml f25a29f6db673e6080dcd5ccd51bab76ab38bff4 > > Diff: https://reviews.apache.org/r/26678/diff/ > > > Testing > ------- > > > Thanks, > > richard zhou > >
