[ 
https://issues.apache.org/jira/browse/SQOOP-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Veena Basavaraj updated SQOOP-1605:
-----------------------------------
    Description: 
{code}
 //Job Manager
     if (lastSubmission != null && lastSubmission.getStatus().isRunning()) {
        throw new SqoopException(DriverError.DRIVER_0002, "Job with id " + 
jobId);
      }
      // TODO(Abe): Call multiple destroyers.
      // TODO(jarcec): We might need to catch all exceptions here to ensure
      // that Destroyer will be executed in all cases.
      // NOTE: the following is a blocking call
      boolean success = submissionEngine.submit(jobRequest);
      if (!success) {
    {code}

{code}
// TestJdbcRepository
  upgraderOrder.verifyNoMoreInteractions();
    validatorOrder.verify(validatorMock, 
times(2)).validateConfigForLink(anyObject());
    // @TODO(Abe): Re-enable job validation?
    validatorOrder.verify(validatorMock, 
times(0)).validateConfigForJob(anyObject());
    validatorOrder.verifyNoMoreInteractions();
  
{code}

{code}
//JobRequestHandler

      // Add associated resources into the bean
      // @TODO(Abe): From/To.
      for( MJob job : jobs) {
        long connectorId = job.getConnectorId(Direction.FROM);
        if(!bean.hasConnectorConfigBundle(connectorId)) {
          bean.addConnectorConfigBundle(connectorId,
   

{code}

// some test code ( jarcec might fix this in his validator code)
   
 // @TODO(Abe): From/To.
   ResourceBundle fromConfigBundle = client.getConnectorConfigBundle(
       job.getConnectorId(Direction.FROM));
 upgraderOrder.verifyNoMoreInteractions();
   validatorOrder.verify(validatorMock, 
times(2)).validateConfigForLink(anyObject());

   // @TODO(Abe): Re-enable job validation?
   validatorOrder.verify(validatorMock, 
times(0)).validateConfigForJob(anyObject());

{code}

{code}

//Mapreduce Submission Engine
 MRConfigurationUtils.setConnectorJobConfig(Direction.FROM, job, 
request.getJobConfig(Direction.FROM));
      MRConfigurationUtils.setConnectorJobConfig(Direction.TO, job, 
request.getJobConfig(Direction.TO));

      MRConfigurationUtils.setDriverConfig(job, request.getDriverConfig());
      // @TODO(Abe): Persist TO schema.
      MRConfigurationUtils.setConnectorSchema(Direction.FROM, job, 
request.getSummary().getFromSchema());
      MRConfigurationUtils.setConnectorSchema(Direction.TO, job, 
request.getSummary().getToSchema());


{code}


  was:
    MRConfigurationUtils.setDriverConfig(job, request.getDriverConfig());
     // @TODO(Abe): Persist TO schema.
     MRConfigurationUtils.setConnectorSchema(Direction.FROM, job, 
request.getSummary().getFromSchema());
     MRConfigurationUtils.setConnectorSchema(Direction.TO, job, 
request.getSummary().getToSchema());
upgraderOrder.verify(connectorUpgraderMock, 
times(1)).upgradeToJobConfig(any(MToConfig.class), any(MToConfig.class));
   upgraderOrder.verifyNoMoreInteractions();
   validatorOrder.verify(validatorMock, 
times(2)).validateConfigForLink(anyObject());
   // @TODO(Abe): Re-enable job validation?
   validatorOrder.verify(validatorMock, 
times(0)).validateConfigForJob(anyObject());
   ConsoleReader reader = new ConsoleReader();
   MJob job = client.createJob(fromLinkId, toLinkId);
   // @TODO(Abe): From/To.
   ResourceBundle fromConfigBundle = client.getConnectorConfigBundle(
       job.getConnectorId(Direction.FROM));
 upgraderOrder.verifyNoMoreInteractions();
   validatorOrder.verify(validatorMock, 
times(2)).validateConfigForLink(anyObject());
   // @TODO(Abe): Re-enable job validation?
   validatorOrder.verify(validatorMock, 
times(0)).validateConfigForJob(anyObject());


> Sqoop2: Misc  From/to cleanups
> ------------------------------
>
>                 Key: SQOOP-1605
>                 URL: https://issues.apache.org/jira/browse/SQOOP-1605
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 1.99.4
>            Reporter: Veena Basavaraj
>            Assignee: Abraham Elmahrek
>
> {code}
>  //Job Manager
>      if (lastSubmission != null && lastSubmission.getStatus().isRunning()) {
>         throw new SqoopException(DriverError.DRIVER_0002, "Job with id " + 
> jobId);
>       }
>       // TODO(Abe): Call multiple destroyers.
>       // TODO(jarcec): We might need to catch all exceptions here to ensure
>       // that Destroyer will be executed in all cases.
>       // NOTE: the following is a blocking call
>       boolean success = submissionEngine.submit(jobRequest);
>       if (!success) {
>     {code}
> {code}
> // TestJdbcRepository
>   upgraderOrder.verifyNoMoreInteractions();
>     validatorOrder.verify(validatorMock, 
> times(2)).validateConfigForLink(anyObject());
>     // @TODO(Abe): Re-enable job validation?
>     validatorOrder.verify(validatorMock, 
> times(0)).validateConfigForJob(anyObject());
>     validatorOrder.verifyNoMoreInteractions();
>   
> {code}
> {code}
> //JobRequestHandler
>       // Add associated resources into the bean
>       // @TODO(Abe): From/To.
>       for( MJob job : jobs) {
>         long connectorId = job.getConnectorId(Direction.FROM);
>         if(!bean.hasConnectorConfigBundle(connectorId)) {
>           bean.addConnectorConfigBundle(connectorId,
>    
> {code}
> // some test code ( jarcec might fix this in his validator code)
>    
>  // @TODO(Abe): From/To.
>    ResourceBundle fromConfigBundle = client.getConnectorConfigBundle(
>        job.getConnectorId(Direction.FROM));
>  upgraderOrder.verifyNoMoreInteractions();
>    validatorOrder.verify(validatorMock, 
> times(2)).validateConfigForLink(anyObject());
>    // @TODO(Abe): Re-enable job validation?
>    validatorOrder.verify(validatorMock, 
> times(0)).validateConfigForJob(anyObject());
> {code}
> {code}
> //Mapreduce Submission Engine
>  MRConfigurationUtils.setConnectorJobConfig(Direction.FROM, job, 
> request.getJobConfig(Direction.FROM));
>       MRConfigurationUtils.setConnectorJobConfig(Direction.TO, job, 
> request.getJobConfig(Direction.TO));
>       MRConfigurationUtils.setDriverConfig(job, request.getDriverConfig());
>       // @TODO(Abe): Persist TO schema.
>       MRConfigurationUtils.setConnectorSchema(Direction.FROM, job, 
> request.getSummary().getFromSchema());
>       MRConfigurationUtils.setConnectorSchema(Direction.TO, job, 
> request.getSummary().getToSchema());
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to