----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26609/#review58698 -----------------------------------------------------------
I have dropped comments on rev 1 since rev2 has changed signidificantly. core/src/main/java/org/apache/sqoop/repository/Repository.java <https://reviews.apache.org/r/26609/#comment99804> cant we take the Direction as an argument, return boolean and extract these lines into a methods? so that froma nd to job validation can be shared. there are places which has done this. If you think it is overkill, I can do it some point later. not a must core/src/main/java/org/apache/sqoop/repository/Repository.java <https://reviews.apache.org/r/26609/#comment99806> one of my question earlier was are we not validating driver config, and looks like we are. core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java <https://reviews.apache.org/r/26609/#comment99807> please remove group, it was my bad I did not clean it up since Abe did not want this called a group - Veena Basavaraj On Oct. 27, 2014, 2:57 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26609/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2014, 2:57 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1576 > https://issues.apache.org/jira/browse/SQOOP-1576 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > I've migrated Repository validation structure to the new infra. I've noticed > some code reuse between Repository and Server Handlers, so I've refactored > those to ConfigUtils class. > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 372e7d3 > common/src/main/java/org/apache/sqoop/model/ModelError.java 35a8943 > common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java 2a7281a > core/src/main/java/org/apache/sqoop/repository/Repository.java bd2a3be > core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java > e11fd10 > server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java > 61b1610 > server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java > b715ad3 > > Diff: https://reviews.apache.org/r/26609/diff/ > > > Testing > ------- > > Unit tests seems to be passing. > > > Thanks, > > Jarek Cecho > >
