> On Oct. 22, 2014, 4:51 a.m., Veena Basavaraj wrote: > > client/pom.xml, line 59 > > <https://reviews.apache.org/r/26931/diff/2/?file=725759#file725759line59> > > > > looks like Jarcec does not like this! as I heard him say so..
Indeed I was concerned about making client dependent on Hadoop libraries as they are usually bringing a lot of other unrelated dependencies (such as Guava, ...). Looking closely at the hadoop-auth dependencies: http://repo1.maven.org/maven2/org/apache/hadoop/hadoop-auth/2.4.0/hadoop-auth-2.4.0.pom It seems that they are reasonable, so I'm +1 on using hadoop-auth on the client side. We should however make that dependency explicit on the client and ship this Hadoop jar, so that clients don't have to download it from somewhere else. - Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26931/#review57744 ----------------------------------------------------------- On Oct. 20, 2014, 2:56 p.m., richard zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26931/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2014, 2:56 p.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > SQOOP-1527: Kerberos support (SPNEGO) in communication between server and > client > This is an initial patch. > This patch depends on SQOOP-1526, which is under reviewing > (https://reviews.apache.org/r/26678/diff/#) > > > Diffs > ----- > > client/pom.xml b2e221ec3b5398c05fa081989e73cf1f2c4d43e5 > client/src/main/java/org/apache/sqoop/client/request/ResourceRequest.java > c84a83e3fd7c550645bda8cf5a0ecc844ef7721d > server/pom.xml 67baaa57da9f69f2e8795107ca1b6186eaef2b9c > server/src/main/java/org/apache/sqoop/filter/SqoopAuthenticationFilter.java > PRE-CREATION > server/src/main/webapp/WEB-INF/web.xml > d31120a367329a7868e64e4215c168bedaf3aac7 > shell/pom.xml 947eab02b229f734640c30de3a7d45ba86656d58 > > Diff: https://reviews.apache.org/r/26931/diff/ > > > Testing > ------- > > > Thanks, > > richard zhou > >
