----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27881/#review60864 -----------------------------------------------------------
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsFromInitializer.java <https://reviews.apache.org/r/27881/#comment102269> Even though I agree we should support nulls, I prefer to return empty schemas where we control the code. Do you see an issue with that? - Gwen Shapira On Nov. 11, 2014, 10:04 p.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27881/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2014, 10:04 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1621 > https://issues.apache.org/jira/browse/SQOOP-1621 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira > > The point of this ticket is to guard the connector developers. > > Internally in Sqoop we can still create a empty Schema object and male sure > we dont have to worry about guarding everyy single place a NPE for null > schema can happen:) > > hence the code change is in the SchemaSerialization class so that we handle > null schema > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java > e006761 > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsFromInitializer.java > 4c6f566 > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsToInitializer.java > bce72b5 > > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java > d5f74f0 > > execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestMRConfigurationUtils.java > fbe3e7b > > Diff: https://reviews.apache.org/r/27881/diff/ > > > Testing > ------- > > yes ( unit and integration ) > > > Thanks, > > Veena Basavaraj > >
