[
https://issues.apache.org/jira/browse/SQOOP-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14208920#comment-14208920
]
Veena Basavaraj commented on SQOOP-1707:
----------------------------------------
After some more discussions here is the outcome.
We have sub classes for each type and it is unclear when would the validate
method would be called from the connectors.
The Initializer is the place where the Schema is created for both the
{code}From{code} and {code}To{code} parts of the connector.
At this point a mapping from native to the IDF supported types in
{code}ColumnType{code} are done. Since it is controlled by the connector, it
seems a overkill to call the validate on itself.
Here is some sample code in GenericJdbcInitializer.
{code}
/**
* Convert given java.sql.Types number into internal data type.
*
* @param sqlType java.sql.Types constant
* @return Concrete Column implementation
*/
public static Column sqlTypeToAbstractType(int sqlType) {
switch (sqlType) {
case Types.SMALLINT:
case Types.TINYINT:
case Types.INTEGER:
return new FixedPoint();
case Types.CLOB:
case Types.VARCHAR:
case Types.CHAR:
case Types.LONGVARCHAR:
case Types.NVARCHAR:
case Types.NCHAR:
case Types.LONGNVARCHAR:
return new Text();
{code}
> SQOOP2: Address the validate method in Column class
> ---------------------------------------------------
>
> Key: SQOOP-1707
> URL: https://issues.apache.org/jira/browse/SQOOP-1707
> Project: Sqoop
> Issue Type: Sub-task
> Components: sqoop2-framework
> Reporter: Veena Basavaraj
> Fix For: 1.99.5
>
>
> Another TODO::)
> {code}
> public boolean validate(Object o) {
> // TODO: Implement this in all subclasses!
> return true;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
