[ 
https://issues.apache.org/jira/browse/SQOOP-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14247528#comment-14247528
 ] 

Hudson commented on SQOOP-1897:
-------------------------------

FAILURE: Integrated in Sqoop2-hadoop100 #732 (See 
[https://builds.apache.org/job/Sqoop2-hadoop100/732/])
SQOOP-1897: Sqoop2: Submission Engine API change for better performance (abe: 
https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=68be30c1cb5065d652c20c89057bf44971b88283)
* core/src/main/java/org/apache/sqoop/driver/JobManager.java
* 
submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java
* core/src/main/java/org/apache/sqoop/driver/SubmissionEngine.java


> Sqoop2: Submission Engine API change for better performance
> -----------------------------------------------------------
>
>                 Key: SQOOP-1897
>                 URL: https://issues.apache.org/jira/browse/SQOOP-1897
>             Project: Sqoop
>          Issue Type: Sub-task
>            Reporter: Veena Basavaraj
>            Assignee: Veena Basavaraj
>             Fix For: 1.99.5
>
>         Attachments: SQOOP-1897-v1.patch, SQOOP-1897.patch
>
>
> {code}
> /**
>    * Return status of given submission.
>    *
>    * @param externalJobId Submission external job id.
>    * @return Current submission status.
>    */
>   public abstract SubmissionStatus status(String externalJobId);
>   /**
>    * Return failure info if the job status is FAILED
>    *
>    * @param submissionId Submission internal id.
>    * @return Current failure info
>    */
>   public abstract SubmissionError error(String externalJobId);
>   /**
>    * Return submission progress.
>    *
>    * Expected is number from interval <0, 1> denoting how far the processing
>    * has gone or -1 in case that this submission engine do not supports
>    * progress reporting.
>    *
>    * @param externalJobId Submission external job id.
>    * @return {-1} union <0, 1>
>    */
>   public double progress(String externalJobId) {
>     return -1;
>   }
>   /**
>    * Return statistics for given submission id.
>    *
>    * Sqoop will call counters only for submission in state SUCCEEDED,
>    * it's consider exceptional state to call this method for other states.
>    *
>    * @param externalJobId Submission external job id.
>    * @return Submission statistics
>    */
>   public Counters counters(String externalJobId) {
>     return null;
>   }
>   /**
>    * Return link to external web page with given submission.
>    *
>    * @param externalJobId Submission external job id.
>    * @return Null in case that external page is not supported or available or
>    *  HTTP link to given submission.
>    */
>   public String externalLink(String externalJobId) {
>     return null;
>   }
> {code}
> can we collapse all this to one API 
> {code}
>   public SubmissionIfo submissionInfo (String externalJobId) {
>     return null;
>   }
> {code}
> We are making 5-6 calls to the MR engine every time we poll for an update in 
> the updateThread, because we dont hold the instance of RunningJob.
> And with spark it may not be the same interface, so this means using 
> externalJobId makes sense



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to