----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29722/#review67485 -----------------------------------------------------------
Ship it! LGTM - Abraham Elmahrek On Jan. 9, 2015, 1:59 a.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29722/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2015, 1:59 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1956 > https://issues.apache.org/jira/browse/SQOOP-1956 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira > > Rename the methods to drop the encode, its obvious:) > > We do not need the indices set in the base class, we can use the switch case > on the column type to determine the type for every row. > > made sure we throw an exception on null schema and validate schema is not > null to avoid the emabarrasing NPE. > > add some comment on why we have a no argument constructor for the IDFs and > that is required for the reflection magic > > > Diffs > ----- > > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/util/SqlTypesUtils.java > 9cfee46 > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestFromInitializer.java > e8c0f0b > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopIDFUtils.java > 26ff629 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/AVROIntermediateDataFormat.java > b12b59a > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java > 33b5d0a > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormat.java > 055b41c > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/JSONIntermediateDataFormat.java > 90294f0 > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/common/TestSqoopIDFUtils.java > 71db8da > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java > e116f3c > execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java > ab2178e > > execution/mapreduce/src/test/java/org/apache/sqoop/job/io/TestSqoopWritable.java > 087d7d3 > > execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java > 7ddaa10 > > execution/mapreduce/src/test/java/org/apache/sqoop/job/util/MRJobTestUtil.java > d498850 > > Diff: https://reviews.apache.org/r/29722/diff/ > > > Testing > ------- > > > Thanks, > > Veena Basavaraj > >
