----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29801/#review67665 -----------------------------------------------------------
Ship it! Ship It! - Abraham Elmahrek On Jan. 12, 2015, 7:32 a.m., richard zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29801/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2015, 7:32 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Do some refactor work and make it ready to add RBAC. > Rename AuthenticationConstants to SecurityConstants. > Rename AuthenticationError to SecurityError. > Rename AuthenticationHandlerFactory to SecurityFactory. > Add Authentication package in org.apache.sqoop.security etc. > > > Diffs > ----- > > core/src/main/java/org/apache/sqoop/security/AuthenticationConstants.java > ec2f32d5fbcf64e53c5cb2873884cd53d25f7316 > core/src/main/java/org/apache/sqoop/security/AuthenticationError.java > abb5c90db6e4a4164755e27b98bb1d2ca022f989 > > core/src/main/java/org/apache/sqoop/security/AuthenticationHandlerFactory.java > b62fe184027c431c7bf9aa2dea1bf9fa9e4742b2 > core/src/main/java/org/apache/sqoop/security/AuthenticationManager.java > a014ab304dff91ff9c420592224dff3a79efcc33 > core/src/main/java/org/apache/sqoop/security/SecurityConstants.java > PRE-CREATION > core/src/main/java/org/apache/sqoop/security/SecurityError.java > PRE-CREATION > core/src/main/java/org/apache/sqoop/security/SecurityFactory.java > PRE-CREATION > dist/src/main/server/conf/sqoop.properties > 2ae1aba6098ce014dd346d37fb12bb7ba5b7429f > docs/src/site/sphinx/SecurityGuideOnSqoop2.rst > 8f9520e15f12e4f8172eaae9a4a756a1dbe916e8 > > security/src/main/java/org/apache/sqoop/security/Authentication/KerberosAuthenticationHandler.java > PRE-CREATION > > security/src/main/java/org/apache/sqoop/security/Authentication/SimpleAuthenticationHandler.java > PRE-CREATION > > security/src/main/java/org/apache/sqoop/security/KerberosAuthenticationHandler.java > 57531b8a71247a8032a8467283e20c2a016eab89 > > security/src/main/java/org/apache/sqoop/security/SimpleAuthenticationHandler.java > c93ff89e7bfc3e349871b42f17d0e866417e037e > server/src/main/java/org/apache/sqoop/filter/SqoopAuthenticationFilter.java > 2b6ef348b3683119c8dbd7e78caed91314d57271 > > Diff: https://reviews.apache.org/r/29801/diff/ > > > Testing > ------- > > local (Kerberos and Simple) > integration-test > > > Thanks, > > richard zhou > >
