----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31586/#review75106 -----------------------------------------------------------
Ship it! This looks good. Calling the "add" method is certainly one way to do this, but using a file and loading every thing dynamically might also make sense. It seems like the DataType class will continue to serve a single purpose, so it seems reasonable to delegate this to a file. Then, test cases could become pluggable / configurable to some extent. Rather than specifying multiple DataType classes, you'd be able to just vary the file. Any ways, this seems like a fine implementation as well. test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/AllTypesTest.java <https://reviews.apache.org/r/31586/#comment122051> +1 * (infinite) - Abraham Elmahrek On March 1, 2015, 5:27 a.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31586/ > ----------------------------------------------------------- > > (Updated March 1, 2015, 5:27 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2160 > https://issues.apache.org/jira/browse/SQOOP-2160 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > I've provided basic infrastructure that is needed for the exhaustive > validations for all data types supported by given database. > > > Diffs > ----- > > > common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java > d8c3c8e > > common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java > 410aa3c > > common-test/src/main/java/org/apache/sqoop/common/test/db/DerbyProvider.java > cf981f5 > > common-test/src/main/java/org/apache/sqoop/common/test/db/types/DatabaseType.java > PRE-CREATION > > common-test/src/main/java/org/apache/sqoop/common/test/db/types/DatabaseTypeList.java > PRE-CREATION > > common-test/src/main/java/org/apache/sqoop/common/test/db/types/DerbyTypeList.java > PRE-CREATION > > common-test/src/main/java/org/apache/sqoop/common/test/db/types/EmptyTypeList.java > PRE-CREATION > > common-test/src/main/java/org/apache/sqoop/common/test/db/types/ExampleValue.java > PRE-CREATION > test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java > 1c5eb10 > test/src/main/java/org/apache/sqoop/test/utils/ParametrizedUtils.java > 02a7315 > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/AllTypesTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/31586/diff/ > > > Testing > ------- > > Added example test case and subset of Derby's types. > > > Thanks, > > Jarek Cecho > >
