> On March 17, 2015, 10:38 a.m., Qian Xu wrote: > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfig.java, > > line 34 > > <https://reviews.apache.org/r/32145/diff/1/?file=897165#file897165line34> > > > > Is it possible to created a jira and use constants for MAX_LENGTH? And > > I might be too concerned about the size maximum in general. According to > > Linux header, filename max length can be 255, path max length can be 4096 > > and uri length can be 2083. > > Jarek Cecho wrote: > Would you feel comfortable to take this to separate standalone JIRA? I > feel that we should think about that more broadly.
I've created SQOOP-2221 to track this. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32145/#review76700 ----------------------------------------------------------- On March 17, 2015, 12:25 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32145/ > ----------------------------------------------------------- > > (Updated March 17, 2015, 12:25 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2201 > https://issues.apache.org/jira/browse/SQOOP-2201 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > I've added ability to the HDFS connector to read Hadoop configuration files > and and broke the dependency on mapreduce's execution engine. > > > Diffs > ----- > > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java > 8237e51 > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsFromInitializer.java > 0a95e07 > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java > cee0a91 > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsPartitioner.java > 78fd60a > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsToInitializer.java > 991e6c9 > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java > fce7728 > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/TestHdfsConnector.java > PRE-CREATION > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfig.java > 146c3b1 > > connector/connector-hdfs/src/main/resources/hdfs-connector-config.properties > 3904856 > test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java > ce6af6e > test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java > 2ef971d > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/AllTypesTest.java > ac90eac > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java > a21e4a1 > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java > 5552e04 > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/IncrementalReadTest.java > 716de30 > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java > f69f08c > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java > f850777 > > test/src/test/java/org/apache/sqoop/integration/connector/kafka/FromHDFSToKafkaTest.java > 83273f1 > > test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java > 3823583 > > Diff: https://reviews.apache.org/r/32145/diff/ > > > Testing > ------- > > I had to update existing integration test as the "reasonable" defaults > weren't applicable to them. > > > Thanks, > > Jarek Cecho > >
