----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33246/#review80287 -----------------------------------------------------------
Ship it! LGTM with just a few thoughts. connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/Destroyer.java <https://reviews.apache.org/r/33246/#comment130095> Add note saying that this will always be ran? core/src/main/java/org/apache/sqoop/driver/JobManager.java <https://reviews.apache.org/r/33246/#comment130094> fromLink, toLink core/src/main/java/org/apache/sqoop/driver/JobManager.java <https://reviews.apache.org/r/33246/#comment130096> This might not be true if the was explicitly stopped. - Abraham Elmahrek On April 15, 2015, 11:24 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33246/ > ----------------------------------------------------------- > > (Updated April 15, 2015, 11:24 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1803 > https://issues.apache.org/jira/browse/SQOOP-1803 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Finalized version of API that will add support to update configuration > objects for incremental import. > > > Diffs > ----- > > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromDestroyer.java > 3a783be > > connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/Destroyer.java > b4ab6d7 > core/src/main/java/org/apache/sqoop/driver/JobManager.java 4044510 > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/IncrementalReadTest.java > 5bde35c > > Diff: https://reviews.apache.org/r/33246/diff/ > > > Testing > ------- > > I've altered JDBC Connector incremental test case to verify the last value - > and it's passing. > > > Thanks, > > Jarek Cecho > >
