> On Aug. 7, 2015, 5:55 a.m., Dian Fu wrote: > > Hi Colin, thanks for the patch. A few comments as follows: > > 1) Seems that these three methods aren't used: > > getTableNameWithoutEscape/getColumnNameWithoutEscape/getConstraintNameWithoutEscape > > 2) The exsiting tables are created with double-quote. This means that the > > existing table names are uppercase. If we access existing tables in > > PostgreSQL without double-quote, PostgreSQL will firstly convert the table > > names to lowercase and then it won't find these tables.
Thanks for the comments: for the point 1: Yes, these methods are not used in this patch, and they are for the JIRA SQOOP-2461. I'll add these changes to the patch for SQOOP-2461. for the point 2: The double-quote is not suitable for some databases, like MySql, and there will be no case-sensitive problem with MySql if table name without double-quote. - Colin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37120/#review94498 ----------------------------------------------------------- On Aug. 5, 2015, 7:35 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37120/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2015, 7:35 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Currently, in the class CommonRepositoryInsertUpdateDeleteSelectQuery, the > tableName and columnName are wrapped with quotation, like > "tableName"."columnName". But some db doesn't support this format, like MySql. > Refactor the code in repository-common to fix this problem. > > > Diffs > ----- > > > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepoUtils.java > 73293c0 > > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java > 1b5e2fb > > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java > 28f5f6a > > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/RepositoryQuery.java > PRE-CREATION > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > 2ba3384 > > Diff: https://reviews.apache.org/r/37120/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
