> On July 30, 2015, 1:45 a.m., Abraham Elmahrek wrote: > > common/src/main/java/org/apache/sqoop/validation/validators/CSVURIValidator.java, > > line 34 > > <https://reviews.apache.org/r/36923/diff/1/?file=1024788#file1024788line34> > > > > I think we have a cool class for this: StringUtils.isNullOrEmpty().
Good point, will fix :) - Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36923/#review93539 ----------------------------------------------------------- On July 29, 2015, 10:27 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36923/ > ----------------------------------------------------------- > > (Updated July 29, 2015, 10:27 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2449 > https://issues.apache.org/jira/browse/SQOOP-2449 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Fixing smaller is things from the findbugs report. I'll tackle the others > separately. This decreases the number of issues from 38 to 24. > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/common/MapContext.java abf5634 > common/src/main/java/org/apache/sqoop/common/MutableMapContext.java 61751bf > common/src/main/java/org/apache/sqoop/common/SupportedDirections.java > 2fae427 > > common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java > 1b1ec28 > common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java > 21fad35 > common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 72565c7 > common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java a2ec587 > common/src/main/java/org/apache/sqoop/model/MJob.java 260b9cd > common/src/main/java/org/apache/sqoop/model/MLink.java 01ff5df > common/src/main/java/org/apache/sqoop/model/MLinkConfig.java 9042ca5 > common/src/main/java/org/apache/sqoop/model/MSubmission.java eb90f9a > > common/src/main/java/org/apache/sqoop/validation/validators/CSVURIValidator.java > 1bef4e7 > > Diff: https://reviews.apache.org/r/36923/diff/ > > > Testing > ------- > > Unit tests are passing. > > > Thanks, > > Jarek Cecho > >
