----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37473/#review95520 -----------------------------------------------------------
Nice, good catch! Just a few high level questions: core/src/main/java/org/apache/sqoop/connector/ConnectorManagerUtils.java (lines 82 - 89) <https://reviews.apache.org/r/37473/#comment150541> Since we've moved to JDK7, can we take advantage of try-with-resources here? https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java (lines 139 - 146) <https://reviews.apache.org/r/37473/#comment150542> Same here, can we use try-with-resources? Jarcec - Jarek Cecho On Aug. 14, 2015, 7:15 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37473/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2015, 7:15 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Fix resource leak problem in SqoopConfiguration and ConnectorManagerUtils > > > Diffs > ----- > > core/src/main/java/org/apache/sqoop/connector/ConnectorManagerUtils.java > 7402c5a > core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java 58c4c34 > > Diff: https://reviews.apache.org/r/37473/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
