> On Aug. 17, 2015, 8:53 p.m., Abraham Elmahrek wrote: > > common/src/test/java/org/apache/sqoop/common/TestMutableMapContext.java, > > line 80 > > <https://reviews.apache.org/r/37463/diff/1/?file=1039792#file1039792line80> > > > > One other test that might be useful is one that performs "setAll", > > except on a map that has some of the keys set. The current implementation > > should overwrite those keys it seems.
I like the way you think about what is the exact semantic here Abe, I'll definitely add that case, thank you! :) - Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37463/#review95634 ----------------------------------------------------------- On Aug. 14, 2015, 1:37 a.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37463/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2015, 1:37 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2480 > https://issues.apache.org/jira/browse/SQOOP-2480 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Provided ability as suggeested on JIRA. > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/common/MutableContext.java 272343f > common/src/main/java/org/apache/sqoop/common/MutableMapContext.java 59c520c > common/src/test/java/org/apache/sqoop/common/TestMutableMapContext.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/37463/diff/ > > > Testing > ------- > > The MutableMapContext didn't have any test, so I've added test covering all > the methods :) > > > Thanks, > > Jarek Cecho > >
