----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37568/#review95724 -----------------------------------------------------------
Overall it looks good to me, just one nit: common-test/src/main/java/org/apache/sqoop/common/test/utils/NetworkUtils.java (lines 87 - 91) <https://reviews.apache.org/r/37568/#comment150842> Can we use the JDK7's capability for multicatch here? https://docs.oracle.com/javase/7/docs/technotes/guides/language/catch-multiple.html Jarcec - Jarek Cecho On Aug. 18, 2015, 6:45 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37568/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2015, 6:45 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Fix smaller-ish warnings in common-test module > > > Diffs > ----- > > > common-test/src/main/java/org/apache/sqoop/common/test/db/types/DefaultTypeList.java > 9abf243 > > common-test/src/main/java/org/apache/sqoop/common/test/db/types/DerbyTypeList.java > 1d4445a > > common-test/src/main/java/org/apache/sqoop/common/test/db/types/MySQLTypeList.java > a11872a > > common-test/src/main/java/org/apache/sqoop/common/test/kafka/KafkaConsumer.java > 78d651b > > common-test/src/main/java/org/apache/sqoop/common/test/kafka/KafkaRealRunner.java > cc9c4fb > > common-test/src/main/java/org/apache/sqoop/common/test/utils/NetworkUtils.java > 7f0f750 > > Diff: https://reviews.apache.org/r/37568/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
